RE: [PATCH v17] virtio-net: support device stats

[Parav Pandit <parav@nvidia.com>]

Hi Xuan,


> From: Parav Pandit <parav@nvidia.com>
> Sent: Wednesday, September 13, 2023 8:55 PM

Two more points I forgot yesterday, can you please include it?

1. Even though 64-bit counters takes a really long time to wrap around, we should write,
That the statistics counter wrap around to zero on overflow.

2. rx_packets consist of received and drop counters both.
For debug purposes this is hard and not clean.
rx_drops is already counting the packets which were dropped.

We should split the good and error counters. i.e. rx_packets to only count the packets which were good receive.
If a new category of drop counter emerge in the future, one does not need to keep subtracing rx_packets from many other counters.
It may not be even reported, when the driver buffer is small.
Hence, we got to split the good with err counters.

This split will align our counters with similar interface standards like mib/snmp and more.

(similar for tx).