Re: [PATCH 4/5] virtqueue: ignore resetting vqs when SUSPEND

["Zhu, Lingshan" <lingshan.zhu@intel.com>]

On 9/14/2023 7:09 PM, Michael S. Tsirkin wrote:
> On Wed, Sep 06, 2023 at 04:16:36PM +0800, Zhu Lingshan wrote:
> > When SUSPEND is set, the device should stabilize the device
> > states and virtqueue states, therefore the device should
> > ignore resetting vqs when SUSPEND is set in device status.
> >
> > Signed-off-by: Zhu Lingshan <lingshan.zhu@intel.com>
> And do what? If you really feel it's important we can prohibit
> driver from touching state. But generally this seems
> un-orthogonal.
As discussed in other threads, we will introduce new feature bit controlling
this.
> > ---
> >   content.tex | 3 +++
> >   1 file changed, 3 insertions(+)
> >
> > diff --git a/content.tex b/content.tex
> > index 9d727ce..cd2b426 100644
> > --- a/content.tex
> > +++ b/content.tex
> > @@ -443,6 +443,9 @@ \subsubsection{Virtqueue Reset}\label{sec:Basic Facilities of a Virtio Device /
> >   The device MUST reset any state of a virtqueue to the default state,
> >   including the available state and the used state.
> >   
> > +If VIRTIO_F_SUSPEND is negotiated and SUSPEND is set in \field{device status},
> > +the device SHOULD ignore resetting any virtqueues.
> > +
> >   \drivernormative{\paragraph}{Virtqueue Reset}{Basic Facilities of a Virtio Device / Virtqueues / Virtqueue Reset / Virtqueue Reset}
> >   
> >   After the driver tells the device to reset a queue, the driver MUST verify that
> > --
> > 2.35.3