RE: [PATCH v3 0/2] Support enabling virtqueue after DRIVER_OK

[Parav Pandit <parav@nvidia.com>]

+ virtio TC.

Hi Michael, Cornelia,

Its been many days, the voting request is not raised for this small patch.

Are you receiving this email?
By any chance, this email has gone to spam/junk directory in your mailbox?

Xuan, Eugenio acked so I at least two mailboxes received in non-junk directory.
I noticed ballot request created 5 days ago for github issue 175, https://www.oasis-open.org/committees/ballot.php?id=3798.

I suspect that, this email is not reaching you for some reason.

Added virtio TC to see if the 3rd ping reaches you.

Flow filters feature is waiting for a while now which depends on this series as users are not able to scale their performance.

Is there anything more to take care in this patch?
Please let me know if I need to fix something in this patch.

> -----Original Message-----
> From: Parav Pandit <parav@nvidia.com>
> Sent: Tuesday, October 10, 2023 10:27 AM
> To: Parav Pandit <parav@nvidia.com>; virtio-comment@lists.oasis-open.org;
> mst@redhat.com; cohuck@redhat.com
> Cc: hengqi@linux.alibaba.com; xuanzhuo@linux.alibaba.com; Shahaf Shuler
> <shahafs@nvidia.com>
> Subject: RE: [PATCH v3 0/2] Support enabling virtqueue after DRIVER_OK
> 
> Hi Michael, Cornelia,
> 
> > From: virtio-comment@lists.oasis-open.org <virtio-comment@lists.oasis-
> > open.org> On Behalf Of Parav Pandit
> > Sent: Monday, October 2, 2023 10:50 AM
> 
> > Hi Michael, Cornelia,
> >
> >
> > > From: Parav Pandit <parav@nvidia.com>
> > > Sent: Monday, October 2, 2023 10:46 AM
> > >
> > > Summary:
> > > ========
> > > This patch enables driver to create virtqueues after DRIVER_OK
> > > status bit is
> > set.
> > >
> > > This patch take the inspiration from the thread [2] with credits to
> > > Eugenio
> > PÃrez.
> > >
> > >
> > > Use cases:
> > > =========
> > > 1. Dynamically create aq when administrative commands to be used.
> > > ate the net device tx/rxq when device is
> > >    opened when deploying for a container.
> > >    In a container, number of virtqueues to be used may be <= max queues.
> > > 3. Dynamically create flow filter queues of netdevice when
> > >    ARFS or ethtool filters are enabled as listed in [1].
> > > 4. Dynamically create rtc functionality related read virtqueue only
> > >    when net device when timestamping to be used.
> > > 5. When XDP program is set, one can create additional XDP specific
> > >    queues without affecting existing queues.
> > >
> > > Hence, This patch introduces an existing queue enable and disable
> > > (aka
> > > reset) facility and a new feature bit to explicitly indicate such
> > > support by the
> > device.
> > >
> > > With this feature, drivers can skip optional queues creation during
> > > driver init time. For example, a Linux net device driver can
> > > create/destroy the transmit and receive queues when net device's
> > > ndo_open() and ndo_stop() callbacks are invoked respectively.
> > >
> > > [1] https://lists.oasis-open.org/archives/virtio-
> > > comment/202308/msg00263.html
> > > [2] https://lists.oasis-open.org/archives/virtio-
> > > comment/202306/msg00097.html
> > >
> > > Patch summary:
> > > ==============
> > > patch-1 fixes to add virtqueue reset conformance references
> > > patch-2 adds VIRTIO_F_RING_DYNAMIC feature bit, requirements
> > >
> > > Please review.
> > >
> > > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/177
> 
> > I have updated v3 to link to the github issue.
> > Now that this small feature was up for few weeks, can you please
> > create the ballot review?
> 
> Can you please create ballot review for 1.4?