RE: [PATCH v3 2/2] content: Support enabling virtqueue after DRIVER_OK stage

[Parav Pandit <parav@nvidia.com>]

> From: Cornelia Huck <cohuck@redhat.com>
> Sent: Tuesday, October 17, 2023 5:55 PM
> 
> On Mon, Oct 02 2023, Parav Pandit <parav@nvidia.com> wrote:
> 
> > Currently, a virtqueue must be enabled before driver has set the
> > DRIVER_OK status bit.
> >
> > spec citation to section "Driver Requirements: Device Initialization"
> >
> > "Perform device-specific setup, including discovery of virtqueues for
> > the device, optional per-bus setup, reading and possibly writing the
> > deviceâs virtio configuration space, and population of virtqueues."
> >
> > This implies that a virtqueue must be enabled before reaching the
> > DRIVER_OK stage. There was no explicit mention about ability to enable
> > the virtqueue after DRIVER_OK stage.
> >
> > In following usecases, creating a virtqueue after DRIVER_OK phase is
> > desired.
> >
> > 1. Dynamically create aq when administrative commands to be used.
> > 2. Dynamically create the net device tx/rxq when device is
> >    opened when deploying for a container.
> >    In a container, number of virtqueues to be used may be <= max queues.
> > 3. Dynamically create flow filter queues of netdevice when
> >    ARFS or ethtool filters are enabled as listed in [1].
> > 4. Dynamically create rtc functionality related read virtqueue only
> >    when net device when timestamping to be used.
> > 5. When XDP program is set, one can create additional XDP specific
> >    queues without affecting existing queues.
> >
> > Hence, This patch introduces an existing queue enable and disable (aka
> > reset) facility and a new feature bit to explicitly indicate such
> > support by the device.
> >
> > With this feature, drivers can skip optional queues creation during
> > driver init time. For example, a Linux net device driver can
> > create/destroy the transmit and receive queues when net device's
> > ndo_open() and ndo_stop() callbacks are invoked respectively.
> >
> > [1]
> > https://lists.oasis-open.org/archives/virtio-comment/202308/msg00263.h
> > tml
> >
> > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/177
> > Signed-off-by: Parav Pandit <parav@nvidia.com>
> > ---
> > changelog:
> > v2->v3:
> > - github fixes tag added
> > v1->v2:
> > - fixed comments from Michael
> > - reduced device and driver normatives (simplified)
> > - replace 'a virtqueue' to 'the virtqueues'
> > - reworded to remove 'interested'
> > - avoided repeated 'device initialization text', replaced with
> >   DRIVER_OK status bit language
> > - avoided confusing text around 'MAY' in the requirements
> > - replaced 'the queue' to 'specific virtqueues'
> > - replaced queue to virtqueue
> > - simplified commit log to talk about msix
> > v0->v1:
> > - fixed comments from Xuan
> > - removed blank lines
> > - fixed wrong requirement link to device in driver section
> > ---
> >  conformance.tex |  2 ++
> >  content.tex     | 49 ++++++++++++++++++++++++++++++++++++++++++++++--
> -
> >  2 files changed, 48 insertions(+), 3 deletions(-)
> >
> 
> (...)
> 
> > @@ -440,6 +440,38 @@ \subsubsection{Virtqueue
> > Re-enable}\label{sec:Basic Facilities of a Virtio Devic  as during
> > initial virtqueue discovery, but optionally with different  parameters.
> >
> > +\subsection{Dynamic Virtqueues}\label{sec:Basic Facilities of a
> > +Virtio Device / Virtqueues / Dynamic Virtqueues}
> > +
> > +When VIRTIO_F_RING_DYNAMIC is not negotiated, the driver enables the
> > +virtqueues during the device initialization sequence, i.e. after the
> > +device sets the FEATURES_OK status bit and before the driver setting the
> DRIVER_OK status bit.
> 
> _Or_ if a virtqueue has been reset and the driver wants to re-enable it, right?
> 
Well no. Because above text is for "enablement", and not re-enablement.
If the driver want to reset and re-enable, it must be enabled in first place before setting driver_ok.
VQ not enabled before driver ok, cannot be reset, and hence cannot be re-enabled.

So I think above text is fine because it says about "enables" and not "re-enables".

> > +
> > +When VIRTIO_F_RING_DYNAMIC is negotiated, the driver can avoid
> > +enabling the virtqueues before setting the DRIVER_OK status bit; the
> > +driver can enable the specific virtqueues after the driver has set the
> DRIVER_OK status bit.
> 
> "the driver is not required to enable every virtqueue it wants to use before
> setting the DRIVER_OK status bit; it can choose to enable a virtqueue even after
> it has set the DRIVER_OK status bit."
> 
Sounds good. Will change it.

> > +The virtqueue enable mechanism is transport specific.
> 
> Would that be the same mechanism as for re-enabling a queue after a queue
> reset? I guess I'm missing the relationship here...
> 
Yes, it is same.
There is no change in enabling/re-enabling the virtqueue after/before DRIVER_OK with/without _dynamic bit.
So no extra text added here.

> > +
> > +\devicenormative{\paragraph}{Enable Virtqueues}{Basic Facilities of a
> > +Virtio Device / Virtqueues / Dynamic Virtqueues / Enable Virtqueues}
> > +
> > +When VIRTIO_F_RING_DYNAMIC is negotiated, the device MUST allow
> > +enabling the virtqueue which was not enabled during the device
> > +initialization phase
> 
> s/the virtqueue/a virtqueue/
> 
Ack.

> > +i.e. after the device has set the FEATURES_OK status bit and before
> > +the driver has set the DRIVER_OK status bit.
> > +
> > +\drivernormative{\paragraph}{Enable Virtqueues}{Basic Facilities of a
> > +Virtio Device / Virtqueues / Dynamic Virtqueues / Enable Virtqueues}
> > +
> > +When VIRTIO_F_RING_DYNAMIC is negotiated, \begin{itemize} \item the
> > +driver MAY enable some or all the virtqueues after the driver has set the
> > +      DRIVER_OK status bit.
> > +
> > +\item the driver MAY enable some of the virtqueues or all the virtqueues or
> none of
> > +      the virtqueues before the driver has set the DRIVER_OK status bit.
> > +\end{itemize}
> 
> Can we write this more concisely as
> 
> "When VIRTIO_F_RING_DYNAMIC is negotiated, the driver MAY enable any
> virtqueue either before or after it has set the DRIVER_OK status bit."
> 
> ?
Looks fine to me. Will change.
> 
> > +
> > +When VIRTIO_F_RING_DYNAMIC is not negotiated, the driver MUST enable
> > +the required number of virtqueues before setting the DRIVER_OK status bit.
> 
> What does "required" mean here? It just chooses to enable the queues it wants
> to use, right?
Right.
Required meaning, whatever number of queues that driver choose to enable, those must be enabled before driver_ok.
So it is "required by the driver".
Would that be ok?

> 
> I'm also still not quite clear how this relates to re-enabling queues after queue
> reset.
Queue can be renabled (after queue reset) only if it was enabled before driver_ok.
This feature bit allows driver to not do such workaround to enable the queue before driver_ok, that it does not want to use in first place.
Not sure I answered, what you ask.
Did I?
	
> 
> > +
> >  \input{split-ring.tex}
> >
> >  \input{packed-ring.tex}
> > @@ -537,7 +569,9 @@ \section{Device Initialization}\label{sec:General
> > Initialization And Device Oper
> >
> >  \item\label{itm:General Initialization And Device Operation / Device
> Initialization / Device-specific Setup} Perform device-specific setup, including
> discovery of virtqueues for the
> >     device, optional per-bus setup, reading and possibly writing the
> > -   device's virtio configuration space, and population of virtqueues.
> > +   device's virtio configuration space.
> > +
> > +\item\label{itm:General Initialization And Device Operation / Device
> Initialization / Virtqueue Setup} Configure and enable the virtqueues.
> >
> >  \item\label{itm:General Initialization And Device Operation / Device
> Initialization / Set DRIVER-OK} Set the DRIVER_OK status bit.  At this point the
> device is
> >     ``live''.
> > @@ -551,6 +585,10 @@ \section{Device Initialization}\label{sec:General
> > Initialization And Device Oper  The driver MUST NOT send any buffer
> > available notifications to  the device before setting DRIVER_OK.
> >
> > +The driver MAY skip step
> > +\ref{itm:General Initialization And Device Operation / Device
> > +Initialization / Virtqueue Setup} when driver has negotiated
> VIRTIO_F_RING_DYNAMIC feature.
> 
> That's confusing: It may not only skip it, but also enable only a subset of the
> queues it wants to use later.
> 
I will add this extra text, that driver may skip or may enable subset of the queues.

> > +
> >  \subsection{Legacy Interface: Device
> > Initialization}\label{sec:General Initialization And Device Operation
> > / Device Initialization / Legacy Interface: Device Initialization}
> > Legacy devices did not support the FEATURES_OK status bit, and thus
> > did  not have a graceful way for the device to indicate unsupported
> > feature @@ -569,7 +607,7 @@ \subsection{Legacy Interface: Device
> > Initialization}\label{sec:General Initializ  Initialization / Re-read
> > FEATURES-OK} were omitted, and steps  \ref{itm:General Initialization
> > And Device Operation /  Device Initialization / Read feature bits},
> > -\ref{itm:General Initialization And Device Operation / Device
> > Initialization / Device-specific Setup} and \ref{itm:General
> > Initialization And Device Operation / Device Initialization / Set
> > DRIVER-OK}
> > +\ref{itm:General Initialization And Device Operation / Device
> > +Initialization / Device-specific Setup}, \ref{itm:General
> > +Initialization And Device Operation / Device Initialization /
> > +Virtqueue Setup} and \ref{itm:General Initialization And Device
> > +Operation / Device Initialization / Set DRIVER-OK}
> >  were conflated.
> >
> >  Therefore, when using the legacy interface:
> > @@ -872,6 +910,11 @@ \chapter{Reserved Feature Bits}\label{sec:Reserved
> Feature Bits}
> >  	\ref{devicenormative:Basic Facilities of a Virtio Device / Feature Bits}
> for
> >  	handling features reserved for future use.
> >
> > +  \item[VIRTIO_F_RING_DYNAMIC(42)] This feature indicates  that the
> > + driver can enable the virtqueues individually after the driver has
> 
> s/the virtqueues/virtqueues/
Ack

> 
> > +  set the status bit of DRIVER_OK.
> > +  See \ref{sec:Basic Facilities of a Virtio Device / Virtqueues / Dynamic
> Virtqueues}.
> > +
> >  \end{description}
> >
> >  \drivernormative{\section}{Reserved Feature Bits}{Reserved Feature
> > Bits}
> 
> We currently have a device normative statement:
> 
> "The device MUST NOT consume buffers or send any used buffer notifications to
> the driver before DRIVER_OK."
> 
> I guess we need to extend that to not doing that for not-yet-enabled queues in
> the dynamic virtqueue case? There's a (transport-specific) point in time when
> the driver tells the device that the queue is ready, right?

We donât need extend this text because device does not know anything about the disabled queue, so it cannot consume any buffer from it anyway.
Above line only applied to the enabled virtqueue.