RE: [virtio-comment] Re: [PATCH v1 3/8] device-context: Define the device context fields for device migration

[Parav Pandit <parav@nvidia.com>]

> From: Michael S. Tsirkin <mst@redhat.com>
> Sent: Wednesday, October 18, 2023 11:50 AM
> 
> On Wed, Oct 18, 2023 at 05:02:25AM +0000, Parav Pandit wrote:
> > > Please just show me your patch resolving these opens, how about
> > > start from defining virito-fs device context and your management VF?
> > As answered, device context infrastructure is done, per device specific device-
> context will be defined incrementally.
> > I will not be including virtio-fs in this series. It will be done
> > incrementally in future utilizing the infrastructure build in this
> > series.
> 
> virtio fs has a lot of context :) I think we do need some way to document which
> devices do and which don't support migration.  Maybe for each device type
> where it's not defined yet, we should add text along the lines of "Device context
> TBD. Devices of this type SHOULD NOT support
> VIRTIO_ADMIN_CMD_DEV_CTX_SIZE_GET and
> VIRTIO_ADMIN_CMD_DEV_CTX_READ commands".
It is really hard to comprehend and conclude that device Foo will not be able to migrate when the device migration work has just began two months ago.
So I wont go overboard to stop them now.

But the requirement you listed about for the commands is covered in the device requirements section in patch_5.