RE: [virtio-comment] [PATCH v1 1/7] virtio-net: Add theory of operation for flow filter

[Parav Pandit <parav@nvidia.com>]

> From: Heng Qi <hengqi@linux.alibaba.com>
> Sent: Thursday, October 19, 2023 12:40 PM
> 
> å 2023/10/7 äå1:14, Parav Pandit åé:
> > Currently packet allow/drop interface has few limitations.
> 
> s/few limitations/a few limitations
> 
> >
> > 1. Driver can either select which MAC and VLANs to consider for
> > allowing/dropping packets, here, the driver has a limitation that
> > driver needs to supply full mac table for each type. Driver cannot add
> > or delete an individual entry.
> >
> > 2. Driver cannot select mac+vlan combination for which to allow/drop
> > packet.
> >
> > 3. Driver cannot not set other commonly used packet match fields
> 
> Remove 'not'.
I think 'not' is fine, as driver cannot set it today. Above lists our current limitations.

For rest of the comments below. I will fix them.