Re: [virtio-comment] Re: [PATCH v1] virtio-crypto: add RSA private key types

[he lei <lhestz@163.com>]

On 2023/5/25 2:34, Michael S. Tsirkin wrote:
> On Thu, May 25, 2023 at 01:01:08PM +0530, Gowrishankar Muthukrishnan wrote:
> > With reference to RFC 3447 Section 3.2, private key exists in any of
> > the two forms, namely:
> >   - exponent
> >   - quintuple
> >
> > Following this, Appendix A.1.2 recommends private key represented
> > including both of the above representations. Hence, for a RSA op,
> > it is required to choose one of these types, hence proposing
> > two private key types.
Do we really need to differentiate between these two formats?
  - RSA Private keys in these two formats can be stored in the same 
RSAPrivateKey structure recommends at Appendix A.1.2 at the same time 
(exponet using n and d, and quintuple using p q...).
  - There is no requirement in the RFC document to distinguish whether 
the private key stored in RSAPrivateKey is in a certain format or both.
  - AFAIK, the implementation interfaces of nettle, gnutls, and openssl 
will not distinguish between these two formats, and will write the keys 
in both formats into rsaprivatekey when exporting the key.

> > Signed-off-by: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>
> > ---
> >   device-types/crypto/description.tex | 12 ++++++++++++
> >   1 file changed, 12 insertions(+)
> >
> > diff --git a/device-types/crypto/description.tex b/device-types/crypto/description.tex


--
Best regards,
he lei
lhestz@163.com