Re: [virtio-dev][PATCH V7 2/2] virtio-spi: add the device specification

[Viresh Kumar <viresh.kumar@linaro.org>]

On 01-12-23, 16:21, Haixu Cui wrote:
> The Virtio SPI (Serial Peripheral Interface) device is a virtual
> SPI controller that allows the driver to operate and use the SPI
> controller under the control of the device.
> 
> This patch adds the specification for virtio-spi.
> 
> Signed-off-by: Haixu Cui <quic_haixcui@quicinc.com>
> ---
>  device-types/spi/description.tex        | 280 ++++++++++++++++++++++++
>  device-types/spi/device-conformance.tex |   7 +
>  device-types/spi/driver-conformance.tex |   7 +
>  3 files changed, 294 insertions(+)
>  create mode 100644 device-types/spi/description.tex
>  create mode 100644 device-types/spi/device-conformance.tex
>  create mode 100644 device-types/spi/driver-conformance.tex
> 
> diff --git a/device-types/spi/description.tex b/device-types/spi/description.tex
> new file mode 100644
> index 0000000..7c81df5
> --- /dev/null
> +++ b/device-types/spi/description.tex
> @@ -0,0 +1,280 @@
> +\section{SPI Controller Device}\label{sec:Device Types / SPI Controller Device}
> +
> +The Virtio SPI (Serial Peripheral Interface) device is a virtual SPI controller that
> +allows the driver to operate and use the SPI controller under the control of the device,

I feel the terminology here is still a bit confusing:

"the SPI controller under the control of the device"

The Virtio SPI controller is "the device" and it is not under its own control.

As I suggested earlier, maybe this should be written as:

"the SPI controller under the control of the guest"

> +either a physical SPI controller, or an emulated one.

I just skimmed through the rest this time. Thanks for your effort.

Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org>

-- 
viresh