[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]
Subject: Re: [virtio-comment] [PATCH 2/2] virtio-net: Clarify the size of the struct virtio_net_hdr for tx
On Fri, 10 Nov 2023 14:40:40 +0200, Parav Pandit <parav@nvidia.com> wrote: > The feature VIRTIO_NET_F_HASH_REPORT only applies to the receive side. > However, when VIRTIO_NET_F_HASH_REPORT feature was introduced, it was > not clarified that the size of the struct virtio_net_hdr on the packet > transmission also uses higher size when VIRTIO_NET_F_HASH_REPORT is > negotiated. > > Explicitly clarify this. > > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/183 > Signed-off-by: Parav Pandit <parav@nvidia.com> > --- > device-types/net/description.tex | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/device-types/net/description.tex b/device-types/net/description.tex > index f5647d4..00ea58d 100644 > --- a/device-types/net/description.tex > +++ b/device-types/net/description.tex > @@ -531,6 +531,12 @@ \subsubsection{Packet Transmission}\label{sec:Device Types / Network Device / De > > \drivernormative{\paragraph}{Packet Transmission}{Device Types / Network Device / Device Operation / Packet Transmission} > > +If VIRTIO_NET_F_HASH_REPORT is not negotiated, the size of the field > +\field{struct virtio_net_hdr} is 12 bytes. > + > +If VIRTIO_NET_F_HASH_REPORT is negotiated, the size of the field > +\field{struct virtio_net_hdr} is 20 bytes. > + How about just say the tx header is equal to the rx hdr? Thanks. > The driver MUST set \field{num_buffers} to zero. > > If VIRTIO_NET_F_CSUM is not negotiated, the driver MUST set > -- > 2.34.1 > > > This publicly archived list offers a means to provide input to the > OASIS Virtual I/O Device (VIRTIO) TC. > > In order to verify user consent to the Feedback License terms and > to minimize spam in the list archive, subscription is required > before posting. > > Subscribe: virtio-comment-subscribe@lists.oasis-open.org > Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org > List help: virtio-comment-help@lists.oasis-open.org > List archive: https://lists.oasis-open.org/archives/virtio-comment/ > Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf > List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists > Committee: https://www.oasis-open.org/committees/virtio/ > Join OASIS: https://www.oasis-open.org/join/ >
[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]