[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]
Subject: RE: [PATCH v1 0/2] virtio-net: Clarify virtio_net_hdr size and rx buffer size
Hi Cornelia, > From: Parav Pandit <parav@nvidia.com> > Sent: Friday, January 5, 2024 1:31 PM > To: virtio-comment@lists.oasis-open.org; mst@redhat.com; > cohuck@redhat.com > Cc: Shahaf Shuler <shahafs@nvidia.com>; xuanzhuo@linux.alibaba.com; > yuri.benditovich@daynix.com; Parav Pandit <parav@nvidia.com> > Subject: [PATCH v1 0/2] virtio-net: Clarify virtio_net_hdr size and rx buffer size > > There are few small issues around size of receive buffer and size of the struct > virtio_net_hdr as following. > > 1. VIRTIO_NET_F_HASH_REPORT is only applicable on the rx side processing. > However it changes the size of the struct virtio_net_hdr for the tx side > as well. This was not clarified when VIRTIO_NET_F_HASH_REPORT feature > was > introduced. > > 2. Receive buffer size calculation description and requirements did not > reflect negotiation of VIRTIO_NET_F_HASH_REPORT. > > 3. Receive buffer size calculation was incorrect for ipv6 guest gso feature. > > Above issue 2 was reported in [1]. > Since issue 2 and 3 both touches the same set of requirements and > description, they are updated under a new issue along with tx side fix as well > touching the clarification needed for VIRTIO_NET_F_HASH_REPORT. > > Hence above three issues are fixed under issue of [2]. > > Patch summary: > patch-1 fixes receive side description and requirement > patch-2 adds transmit side clarification for VIRTIO_NET_F_HASH_REPORT > > changelog: > v0->v1: > - addressed comments from Xuan to rewrite tx normative > Can you please raise the voting request for these two small description changes? > Parav Pandit (2): > virtio-net: Fix receive buffer size calculation text > virtio-net: Clarify the size of the struct virtio_net_hdr for tx > > device-types/net/description.tex | 28 +++++++++++++++++++++------- > 1 file changed, 21 insertions(+), 7 deletions(-) > > -- > 2.34.1
[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]