RE: [virtio-comment] [PATCH] sound: add sampling rates 12000Hz and 24000Hz

["Pape, Andreas (ADITG/ESS3)" <apape@de.adit-jv.com>]

Hello Anton,

finally got it moving,
I'd appreciate your feedback..

Sorry for the noise.

Regards,
Andreas

-----Original Message-----
From: Cornelia Huck <cohuck@redhat.com> 
Sent: Donnerstag, 8. Februar 2024 07:57
To: Pape, Andreas (ADITG/ESS3) <apape@de.adit-jv.com>; virtio-comment@lists.oasis-open.org; virtio-dev@lists.oasis-open.org
Subject: Re: [virtio-comment] [PATCH] sound: add sampling rates 12000Hz and 24000Hz

On Mon, Feb 05 2024, "Pape, Andreas (ADITG/ESS3)" <apape@de.adit-jv.com> wrote:

> 24kHz is used for 'super wideband' voice transmission 12kHz is added 'for completeness'
> Fixes: 
> https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_oasis-
> 2Dtcs_virtio-2Dspec_issues_184&d=DwICAQ&c=euGZstcaTDllvimEN8b7jXrwqOf-
> v5A_CdpgnVfiiMM&r=aWTtojMtCV9SvyEwkpBNuTjVnzMm-Wc09ONKDmVeCUo&m=XDUsTd
> yRiIauEU-zsLLjB_yiYUGbdqBUswI9y-mAtk_EfNzT50LhiT6Vi3PcX0os&s=h-kPfeihz
> bJFOhrtv05pTeRJq9ilzHEEbdN2WiJ5Qcw&e=
>
> Signed-off-by: Andreas Pape <apape@de.adit-jv.com>
> ---
>  device-types/sound/description.tex | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/device-types/sound/description.tex 
> b/device-types/sound/description.tex
> index 54c9c8e..bad4415 100644
> --- a/device-types/sound/description.tex
> +++ b/device-types/sound/description.tex
> @@ -504,7 +504,9 @@ \subsubsection{PCM Control Messages}\label{sec:Device Types / Sound Device / Dev
>      VIRTIO_SND_PCM_RATE_96000,
>      VIRTIO_SND_PCM_RATE_176400,
>      VIRTIO_SND_PCM_RATE_192000,
> -    VIRTIO_SND_PCM_RATE_384000
> +    VIRTIO_SND_PCM_RATE_384000,
> +    VIRTIO_SND_PCM_RATE_12000,
> +    VIRTIO_SND_PCM_RATE_24000
>  };
>  
>  struct virtio_snd_pcm_info {

I think there had been a Reviewed-by: for a previous iteration of this patch? We can add it while applying (after voting, which I'm going to initiate); but I'd appreciate it if the previous reviewer could reply here again.