Re: [PATCH v11 6/6] virtio-balloon: VIRTIO_BALLOON_F_CMD_VQ

[Wei Wang <wei.w.wang@intel.com>]

On 06/12/2017 10:07 PM, Dave Hansen wrote:
> On 06/09/2017 03:41 AM, Wei Wang wrote:
> > +	for_each_populated_zone(zone) {
> > +		for (order = MAX_ORDER - 1; order > 0; order--) {
> > +			for (migratetype = 0; migratetype < MIGRATE_TYPES;
> > +			     migratetype++) {
> > +				do {
> > +					ret = report_unused_page_block(zone,
> > +						order, migratetype, &page);
> > +					if (!ret) {
> > +						pfn = (u64)page_to_pfn(page);
> > +						add_one_chunk(vb, vq,
> > +						PAGE_CHNUK_UNUSED_PAGE,
> > +						pfn << VIRTIO_BALLOON_PFN_SHIFT,
> > +						(u64)(1 << order) *
> > +						VIRTIO_BALLOON_PAGES_PER_PAGE);
> > +					}
> > +				} while (!ret);
> > +			}
> > +		}
> > +	}
> This is pretty unreadable.    Please add some indentation.  If you go
> over 80 cols, then you might need to break this up into a separate
> function.  But, either way, it can't be left like this.

OK, I'll re-arrange it.

Best,
Wei