Re: [virtio-dev] [PATCH V2 1/1] virtio-balloon: fix internal stat name array to match Linux kernel

[Thomas Tai <thomas.tai@oracle.com>]

On 2018-05-10 04:18 AM, Stefan Hajnoczi wrote:
> On Wed, May 09, 2018 at 03:53:05PM -0400, Thomas Tai wrote:
> > The Linux kernel commit b40000325044 ("virtio_balloon: add array
> > of stat names") defines an array of stat name strings for consumers
> > of the virtio interface to use via the virtio_balloon.h header
> > file, rather than requiring each consumer to define its own. But at
> > present, the stat names defined in this array by the Linux kernel
> > do not match up with those defined internally by QEMU.
> >
> > This patch fixes this inconsistency by importing the header file
> > from linux and use the new macro to construct the balloon_stat_names
> > array.
> >
> > Signed-off-by: Jonathan Helman <jonathan.helman@oracle.com>
> > Signed-off-by: Thomas Tai <thomas.tai@oracle.com>
> > Cc: Rob Gardner <rob.gardner@oracle.com>
> > ---
> >   docs/virtio-balloon-stats.txt                   |  2 ++
> >   hw/virtio/virtio-balloon.c                      | 13 ++-----------
> >   include/standard-headers/linux/virtio_balloon.h | 19 ++++++++++++++++++-
> >   3 files changed, 22 insertions(+), 12 deletions(-)
>
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

Thank you Stefan.

-Thomas