Re: [PATCH v2 09/23] virtio-gpu api: blob resources

[Gurchetan Singh <gurchetansingh@chromium.org>]

On Tue, Sep 8, 2020 at 11:55 PM Gerd Hoffmann <kraxel@redhat.com> wrote:

 Hi,

> @@ -100,7 +102,7 @@ struct drm_virtgpu_resource_info {
>Â Â Â Â__u32 bo_handle;
>Â Â Â Â__u32 res_handle;
>Â Â Â Â__u32 size;
> -Â Â Â__u32 stride;
> +Â Â Â__u32 blob_mem;
>Â };

Huh? This is not in the virtio spec update proposed.

>Â struct drm_virtgpu_3d_box {
> @@ -117,6 +119,8 @@ struct drm_virtgpu_3d_transfer_to_host {
>Â Â Â Âstruct drm_virtgpu_3d_box box;
>Â Â Â Â__u32 level;
>Â Â Â Â__u32 offset;
> +Â Â Â__u32 stride;
> +Â Â Â__u32 layer_stride;
>Â };

Same here.

>Â struct drm_virtgpu_3d_transfer_from_host {
> @@ -124,6 +128,8 @@ struct drm_virtgpu_3d_transfer_from_host {
>Â Â Â Âstruct drm_virtgpu_3d_box box;
>Â Â Â Â__u32 level;
>Â Â Â Â__u32 offset;
> +Â Â Â__u32 stride;
> +Â Â Â__u32 layer_stride;
>Â };Â

And here.

Separated out the virtio and DRM api changes, as per your recommendation. The virtio spec changes should match v6 of the proposed spec. Explanations for these specific DRM changes here are in patch 16 & patch 17 of the v3 implementation.Â

Â

take care,
 Gerd

PS: cherry-picked patches 1-3 into drm-misc-next.