Re: [virtio-dev] Re: [PATCH v1] virtio-mmio: Specify wait needed in driver during reset

[Srivatsa Vaddagiri <svaddagi@qti.qualcomm.com>]

> > Thinking on those lines, I am wondering if we can avoid the feature bit

> > all together based on that logic.

> >

> > 1) Driver writes 0 to status register - device initiates reset sequence

> > 2) Driver reads status - return 0x40 (VIRTIO_CONFIG_S_NEEDS_RESET)

> >    if reset sequence is in progress, otherwise return 0

>

> I don't think we can have the device return NEEDS_RESET in that case;

> that status is supposed to indicate "that the device has experienced an

> error from which it can't recover" -- which is not the case here,

> especially since the driver has already initiated a reset.

In that case, how about introducing a new status bit, RESET_IN_PROGRESS (bit 4 or

some other unused bit) and return that to indicate reset is not complete?

Its not clear otherwise what the device is supposed to return in such case.

---

Qualcomm Innovation Center, Inc. is submitting the attached "feedback" as a

non-member to the virtio-dev mailing list for consideration and inclusion.