Re: [PATCH v3] virtio-pmem: PMEM device spec

[Pankaj Gupta <pankaj.gupta.linux@gmail.com>]

> > > > +Requests have the following format:
> > > > +
> > > > +\begin{lstlisting}
> > > > +struct virtio_pmem_req {
> > > > +        le32 type;
> > > > +};
> > > > +\end{lstlisting}
> > > > +
> > > > +\field{type} is the request command type.
> > >
> > > Where are the type constants defined? I was expecting a flush request
> > > type constant:
> > >
> > >   /* Request types */
> > >   #define VIRTIO_PMEM_REQ_T_FLUSH 0
> >
> > Removed this in current version. Thinking this might be driver specific detail.
> > Will add again.
>
> Constant values that the driver places into the "type" field need to be
> defined in the specification. Otherwise there's a risk that drivers
> place different values into the field and we cannot add new types of
> requests in the future.

Agree.

Waiting for any other comment before I send next version with the
minor changes suggested
by Stefan in v3.

Thanks,
Pankaj