[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]
Subject: Re: [virtio-comment] Re: [PATCH v18] virtio-net: support inner header hash
On Wed, Jun 21, 2023 at 07:39:19PM +0000, Parav Pandit wrote: > > > From: Michael S. Tsirkin <mst@redhat.com> > > Sent: Wednesday, June 21, 2023 3:36 PM > > > > It can be helpful for debugging. E.g. if driver sets a bit that device does not > > recognize, it can figure out that driver has it set in supported mask. > Device is reporting error code anyway when it receives a unexpected command contents. To driver, yes. But if you are debugging this from software device side then getting info about driver state is helpful. > > Or if it seems like a waste we can just ask drivers to put 0 there, works for me > > too. > > I fail to see this being any better or equal to two structures. One structure is just simpler for software than two. > > > > > > > Two structures are cleaner. > > > > Frankly what's cleaner is what RSS is doing, supported mask in config space. > > Was this discussed in some version? I don't remember. > > > Yes, we discussed. Couldn't find it and I don't want us to repeat same agruments. Which version had this field in config space? > > This publicly archived list offers a means to provide input to the > OASIS Virtual I/O Device (VIRTIO) TC. > > In order to verify user consent to the Feedback License terms and > to minimize spam in the list archive, subscription is required > before posting. > > Subscribe: virtio-comment-subscribe@lists.oasis-open.org > Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org > List help: virtio-comment-help@lists.oasis-open.org > List archive: https://lists.oasis-open.org/archives/virtio-comment/ > Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf > List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists > Committee: https://www.oasis-open.org/committees/virtio/ > Join OASIS: https://www.oasis-open.org/join/
[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]