Re: [virtio-dev] Re: [PATCH v12] virtio-net: support device stats

["Michael S. Tsirkin" <mst@redhat.com>]

On Wed, Jul 12, 2023 at 02:24:32PM +0200, Cornelia Huck wrote:
> On Wed, Jul 12 2023, "Michael S. Tsirkin" <mst@redhat.com> wrote:
> 
> > On Wed, Jul 12, 2023 at 07:44:01PM +0800, Xuan Zhuo wrote:
> >> On Wed, 12 Jul 2023 07:34:38 -0400, "Michael S. Tsirkin" <mst@redhat.com> wrote:
> >> > On Tue, Mar 15, 2022 at 11:24:02AM +0800, Xuan Zhuo wrote:
> >> > > This patch allows the driver to obtain some statistics from the device.
> >> > >
> >> > > In the back-end implementation, we can count a lot of such information,
> >> > > which can be used for debugging and judging the running status of the
> >> > > back-end. We hope to directly display it to the user through ethtool.
> >> > >
> >> > > To get stats atomically, try to get stats for all queue pairs in one
> >> > > command.
> >> > >
> >> > > Signed-off-by: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
> >> > > Suggested-by: Michael S. Tsirkin <mst@redhat.com>
> >> >
> >> > Functionally, I think this is close to ok now.  But the text needs
> >> > of work.  Are you trying to target 1.3 with this?
> >> 
> >> I personally worry about that 1.3 may be too late, if possible, I would like to
> >> respond as soon as possible.
> >> 
> >> I really don't really care if it can get into 1.3 or not but I do hope that this
> >> can be done as soon as possible.
> >> 
> >> Thanks.
> >
> > Yes we were supposed to freeze for 1.3. This change can be merged on a
> > main branch after 1.3 forks and is under review.
> 
> Nod, that's what I would prefer to do. Being merged on virtio-next
> should be enough for including device/driver implementations.

Except I'd prefer a v1.3 branch instead of a next branch - adding things
on the branch should be harder, not easier.

-- 
MST