[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]
Subject: [PATCH 3/3] ccw: clarify indicator requirements
The driver must set up its two-state indicators in a way that the device can set indicator bits for every queue it provides. Better be clear about that and make it an explicit requirement. VIRTIO-158 Reviewed-by: Pierre Morel <pmorel@linux.vnet.ibm.com> Reviewed-by: Halil Pasic <pasic@linux.vnet.ibm.com> Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com> --- conformance.tex | 1 + content.tex | 6 ++++++ 2 files changed, 7 insertions(+) diff --git a/conformance.tex b/conformance.tex index ca08486..fe80201 100644 --- a/conformance.tex +++ b/conformance.tex @@ -80,6 +80,7 @@ A Channel I/O driver MUST conform to the following normative statements: \item \ref{drivernormative:Virtio Transport Options / Virtio over channel I/O / Basic Concepts} \item \ref{drivernormative:Virtio Transport Options / Virtio over channel I/O / Device Initialization / Setting the Virtio Revision} \item \ref{drivernormative:Virtio Transport Options / Virtio over channel I/O / Device Initialization / Communicating Status Information} +\item \ref{drivernormative:Virtio Transport Options / Virtio over channel I/O / Device Initialization / Setting Up Indicators / Setting Up Two-Stage Queue Indicators} \item \ref{drivernormative:Virtio Transport Options / Virtio over channel I/O / Device Operation / Host->Guest Notification / Notification via Adapter I/O Interrupts} \item \ref{drivernormative:Virtio Transport Options / Virtio over channel I/O / Device Operation / Guest->Host Notification} \end{itemize} diff --git a/content.tex b/content.tex index 4abd4eb..0b16fd8 100644 --- a/content.tex +++ b/content.tex @@ -2849,6 +2849,12 @@ If the driver has already set up classic queue indicators via the CCW_CMD_SET_IND command, the device MUST post a unit check with command reject to any subsequent CCW_CMD_SET_IND_ADAPTER command. +\drivernormative{\subparagraph}{Setting Up Two-Stage Queue Indicators}{Virtio Transport Options / Virtio over channel I/O / Device Initialization / Setting Up Indicators / Setting Up Two-Stage Queue Indicators} +The driver MUST ensure that both the summary indicator and the device +indicator area are writeable by the device. In particular, the driver +MUST ensure that a device indicator bit is writeable for each virtqueue +that the device provides. + \paragraph{Legacy Interfaces: A Note on Setting Up Indicators}\label{sec:Virtio Transport Options / Virtio over channel I/O / Device Initialization / Setting Up Indicators / Legacy Interfaces: A Note on Setting Up Indicators} In some cases, legacy devices will only support classic queue indicators; -- 2.11.0
[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]