[OASIS Issue Tracker] (AMQPBINDMAP-15) update handling of correlation ID for interop

[OASIS Issues Tracker <workgroup_mailer@lists.oasis-open.org>]

    [ https://issues.oasis-open.org/browse/AMQPBINDMAP-15?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=62953#comment-62953 ] 

Robert Gemmell commented on AMQPBINDMAP-15:
-------------------------------------------

Hi John,

The scenario you outlined isn't quite how things would happen. The idea is for the synthesis to be reversible, and its true that Step 4 would follow from Step 3 if it happened, but Step 2 isn't what would happen from the given starting point. An arriving AMQP correlation-id string value that doesnt start with "ID:" wont be modified at all for use as the JMSCorrelationID, in JMS terms it would be treated as being an application-specific value. Also the AMQP_STRING escape should rarely be used, its only really for use to escape the other encoding hints already being at the start of the string after "ID:", which I wouldnt expect too often.

Taking your scenario through from step 1, I would see it as going:
1. [AMQP] sends message #1 with correlation-id 'my-non-prefixed-string-id'
2. [JMS] receives message #1 with JMSCorrelationID "my-non-prefixed-string-id"
3. [JMS] sends message #2 with same JMSCorrelationID "my-non-prefixed-string-id"
4. [AMQP] receives message #2 with correlation-id 'my-non-prefixed-string-id'

If you instead take the scenario as going from message-id --> correlation-id, then I would see it being:
1. [AMQP] sends message #1 with message-id 'my-non-prefixed-string-id'
2. [JMS] receives message #1 with JMSMessageID "ID:AMQP_NO_PREFIX:my-non-prefixed-string-id"
3. [JMS] sends message #2 with same JMSCorrelationID "ID:AMQP_NO_PREFIX:my-non-prefixed-string-id"
4. [AMQP] receives message #2 with correlation-id 'my-non-prefixed-string-id'

If the AMQP sender were to actually send strings of format 'ID:foo' then the value would again be unchanged (so long as <foo> doesnt begin with one of the AMQP_X hints), this time for both correlation and message ID usage.

> update handling of correlation ID for interop
> ---------------------------------------------
>
>                 Key: AMQPBINDMAP-15
>                 URL: https://issues.oasis-open.org/browse/AMQPBINDMAP-15
>             Project: OASIS Advanced Message Queuing Protocol (AMQP) Bindings and Mappings (AMQP-BINDMAP) TC
>          Issue Type: Bug
>          Components: JMS Mapping
>    Affects Versions: wd06
>            Reporter: Steve Huston
>            Assignee: Robert Gemmell
>            Priority: Blocker
>
> An issue with interop between JMS and non-JMS clients when using correlation ID values on messages.
> If a JMS application sets JMSCorrelationID on a Message, it can do so either using a JMSMessageID value (a String beginning with "ID:") or an application-specific string value. Previously we decided that the "ID:" prefix of a JMSMessageID should not be sent on the wire so other non-JMS client need not deal with it, and a message-id from a non-JMS client would round-trip correctly as a correlation-id value. For this reason, and also to accomodate the 4 different types of message-id that the core spec defines (string, ulong, uuid, and binary) and ensure preservation of the AMQP wire type when round-tripping these values into the JMS application layer and back to the AMQP layer, the client manages/translates the message-id and correlation-id values, and utilises the x-opt-app-correlation-id message annotation to record when an application-specific JMSCorrelationID value is in use.
> An issue arises if an application-specific string is sent as the JMSCorrelationID value on a request message (from JMS app A), and received by a a non-JMS app B which then sends a new reply message containing the same correlation-id value. If the non-JMS client/app B does not set the x-opt-app-correlation-id on its reply message, then the JMS app A receiving the reply message will then treat the correlation-id value as being representative of a JMSMessageID value and return incorrectly return an "ID:" prefixed value for the message JMSCorrelationID. This would then no longer match the JMSCorrelationID sent on the original request message.
> Related sections:
> 3.2.1.1 JMSMessageID And JMSCorrelationID Handling
> 3.2.1 JMS Headers (specifically the JMSMessageID and JMSCorrelationID entries)
> 3.3.2 Properties Section ( specifically the message-id and correlation-id entries)
> Section references from WD6: https://www.oasis-open.org/committees/document.php?document_id=56418&wg_abbrev=amqp-bindmap



--
This message was sent by Atlassian JIRA
(v6.2.2#6258)