Re: [amqp] Groups - AMQP Management v1.0 wd03 uploaded

[Ted Ross <tross@redhat.com>]

David,

Thanks for the update.  I have some questions/suggestions about the new QUERY operation.

First, I'm a little confused by the fact that "Attributes" is mandatory and "entityTypes" is optional.  To my understanding, attributes have type-specific meaning, so searching for common attributes over a set of types doesn't seem that useful to me.  I would suggest that "entityTypes" be the mandatory property and "Attributes" be optional.

"Attributes" is defined as a string, yet it is described as a "set".  I think this property should be a list of strings where each item is an attribute name.  If not supplied, all attributes of the returned entities should be included in the response.  If supplied, only the listed attributes should be included.

"entityTypes" is defined as a list which suggests that a response may contain entities of multiple types.  This further suggests that the optional "type" attribute really isn't optional because without it, there would not be a way to determine the types of the entities in the response.  I suggest that "entityTypes" be renamed "entityType", made mandatory, and changed to a string type.  This means that all QUERY operations are on a single type.  This allows the types of the entities in the response to be inferred as opposed to having to be individually identified.

The "Count" property in the response is redundant with the count field of the list in the amqp-value body.  It would be simpler to have a property of "maxCount" that doesn't carry any information back to the requestor.  Depending on how the management agent is implemented, it might be onerous to encode the properties, then encode the body only to have to go back and re-encode one of the properties based on the size of the body.

Regards,

-Ted

On 01/13/2014 06:49 PM, David Ingham wrote:

Submitter's message
A work-in-progress version with changes made to the core set of Manageable Entity Operations and Management Node Operations.
-- Mr. David Ingham

Document Name: AMQP Management v1.0 wd03

---

Description
A work-in-progress version with changes made to the core set of Manageable
Entity Operations and Management Node Operations.
Download Latest Revision
Public Download Link

---

Submitter: Mr. David Ingham
Group: OASIS Advanced Message Queuing Protocol (AMQP) TC
Folder: Working Documents
Date submitted: 2014-01-13 15:49:05