Re: [cgmo-webcgm] Review Assigment

[Lofton Henderson <lofton@rockynet.com>]

Thanks Don.  You win for the first review-assignment completion.

For Stuart -- I think test reviews should be processed in TC telecons.  See 
more below.

A couple questions to Don:

1.) From your comments, it looks like you used did you use 
ftp://ftp.cgmlarson.com/ReviewerInstructions.html.  Did you find it 
helpful?  Do you have any suggestions for improvement?

2.) Did your test-review work lead to any questions, issues, editorials, 
etc about the spec itself?

A question for everyone:

About #2:  at least a couple of us are finding it puzzling that 
implementation work and test-writing/reviewing is leading to ZERO comments 
on the spec, with the exception of Benoit's work.  I would expect that any 
close attention to the spec would necessarily lead to questions, 
editorials, proposals for more functionality/parameters, ambiguities, etc, 
even for simple functionality.  There are bound to be errors and 
ambiguities still.  Any opinions, why we aren't getting spec. feedback?

About Review processing:

I think it should be a topic at the TC telecon.  It would be good to get 
the test authors' reactions to reviews.  Finally, the TC should come to 
closure by accepting (or not) the reviews' conclusions, directing the 
authors to implement them (or not), and then the test will transitions to 
'approved'.

Regards,
-Lofton.

At 09:15 AM 11/6/2008 -0600, Don wrote:
>Lofton,
>
>I have completed my test review assignment.
>
>-------------------------------------------------------------------------------------------
>
>Review comments-
>
>For all tests-
>
>1. Html is using <script type="Javascript">
>should be - <script type="text/ecmascript">
>
>2. nomenclature used in test descriptions and html title not consistent 
>with spec.
>
>3. All CGMs verified in Metachek.
>
>
>Recommended changes for each test:
>
>1) Test: setGetFillStyles2.0
>
>Description: tests get/set fill-color style property (picture and APS level)
>
><title>Fill Color Style Property Test Page</title>
><script type="text/ecmascript">
>
>2) setGetLineStyles2.0
>
>This test should be re-named "setGetStrokeStyles" since we call it Stroke 
>Style not Line Style.
>
>Description: tests get/set stroke-color & stroke-weight style properties 
>(picture and APS level)
>
><title>Stroke Color & Weight Style Properties Test Page</title>
><script type="text/ecmascript">
>
>3) setGetIntensity
>
>Description: tests get/set intensity style property (picture and APS level)
><title>Intensity Style Property Test Page</title>
><script type="text/ecmascript">
>
>4) setGetStrokeOffset
>
>Description: tests get/set stroke-offset style property (picture and APS 
>level)
><title>APS Stroke Offset Style Property Test Page</title>
><script type="text/ecmascript">
>
>5) setGetStrokeType
>
>Description: tests stroke-type style property (APS level)
><title>APS Stroke Type Style Property Test Page</title>
><script type="text/ecmascript">
>
>
>
>Regards,
>Don Larson
>
>---------------------------------------------------------------------
>To unsubscribe from this mail list, you must leave the OASIS TC that
>generates this mail.  Follow this link to all your TCs in OASIS at:
>https://www.oasis-open.org/apps/org/workgroup/portal/my_workgroups.php