[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]
Subject: RE: re[4]: [cgmo-webcgm] review of aci files
Don -- the action item is back to you to correct the metafile errors from
Rob and Ulrich. Can you fix these problems? (Matrix [1] is updated.)
Rob, Ulrich, All --
Does this accurately summarize the metafile problems, as detected by
MetaCheck (and reviewers)?
1.) Max VDC Extent violation;
2.) "ColourClass:colour" problem (MetaCheck bug);
3.) ProfileEd is 2.0 (ought to be 2.1);
4.) Max Colour Index violation;
5.) Font List violation ('arial' in Font List but no Font Properties element).
Overall opinion: While these problems must be fixed, they are in some
sense "formal", and I think most of them will not affect an implementor's
ability to use the file. The overall structure and content of the test is
appropriate. Details:
#1: the MaxVdcExt element is a pain in the butt! Should never have been
added to CGM:1999. But ... there it is, so may as well bite the bullet and
make it right. (IMHO, this is purely a "formal" error -- should have no
practical impact on early users of the test.)
#2: metacheck bug, nothing need be changed.
#3: ought to be 2.1 for new metafiles in the 2.1 test suite, yes? (See
Rob's comments below about this -- MetaCheck will gripe but we know it's
not a problem.)
#4: Another "formal" violation -- I would expect minimal impact on early
users of the test.
#5: This is somewhat at the heart of the test. While it *might* not
impact early users of the test, on the other hand it might. It could be
fixed by either changing the font to 'helvetica', or by adding a Font
Properties element.
Thoughts (anyone)?
Btw, once these metafile problems are resolved, we will have a big batch of
tests ready for "Approved", I think.
Regards,
-Lofton.
[1] ftp://ftp.cgmlarson.com/test-matrix.htm
At 05:02 PM 3/19/2009 -0600, Robert Orosz wrote:
>Don,
>
>The binary CGMs that you've submitted are invalid. I've attached a ZIP file
>containing the MetaCheck trace output for each.
>
>Lofton,
>
>Please reset the status of these tests to reworking.
>
> aciDefaultFont
> aciEdgeAttr
> aciFontNormalization
> aciGenericFonts
> aciHatchStyleDef
> aciLineAttr
> aciLineEdgeTypeDef
> aciMapListOrder
> aciMitreLimit
> aciRestrictedTextType
> aciSimpleFontSubsitution
>
>The CGM conformance violation is the same in each; namely, the VDC Extent
>exceeds the specified Maximum VDC Extent. Each CGM has (1,1) (-1,-1) for
>the Maximum VDC Extent and that is well exceeded by the VDC Extent in each
>case.
>
>These CGMs also highlight an inconsistency in the WebCGM profile. T.16.8
>allows for 16-bit color index precision. However, T.16.9 caps the maximum
>color index at 255, i.e. effectively limiting you to only 8-bit color index
>precision. We should make these two table rows in the PPF consistent with
>each other.
>
>More later,
>
>Rob
>
>-----Original Message-----
>From: 'Don Larson (E-mail)' [mailto:dlarson@cgmlarson.com]
>Sent: Thursday, March 19, 2009 7:37 AM
>To: Lofton Henderson
>Cc: 'CGM Open WebCGM TC'
>Subject: re[4]: [cgmo-webcgm] review of aci files
>
>
>Lofton,
>
>I have corrected and updated the following ACI files:
>
> aciFontNormalization.aci
> aciLineAttr.aci
> aciHatchStyleDef.aci
> aciMitreLimit.aci
>
>
>Also all the ACI related CGMs have been converted to binary:
>
> aciDefaultFont.cgm
> aciEdgeAttr.cgm
> aciFontNormalization.cgm
> aciGenericFonts.cgm
> aciHatchStyleDef.cgm
> aciLineAttr.cgm
> aciLineEdgeTypeDef.cgm
> aciMapListOrder.cgm
> aciMitreLimit.cgm
> aciRestrictedTextType.cgm
> aciSimpleFontSubsitution.cgm
>
>
>Regards,
>Don
>
> > At 10:22 AM 3/17/2009 -0500, Forrest Carpenter wrote:
> > >Don,
> > >
> > >aciMitreLimit aci file <mitreLimit limitVal=5 />
> > > should be <mitreLimit limitVal="5" />
> > >CGM file is clear text, should be binary
> > >
> > >aciRestrictedTextType aci file OK
> > >CGM file is clear text, should be binary
> > >
> > >aciLineEdgeType aci file OK
> > >CGM file is clear text, should be binary
> > >
> > >aciHatchStyleDef aci file </hatchStyleDef>
> > > should be />
> > >CGM file is clear text, should be binary
> > >
> > >aciLineAtt aci file <lineCap lineCapInd=2 lineDashInd=3 />
> > > <lineJoin lineJoinInd=4 />
> > > <lineTypeCont lineContMode=3 />
> > > Should be <lineCap lineCapInd="2" lineDashInd="3" />
> > > <lineJoin lineJoinInd="4" />
> > > <lineTypeCont lineContMode="3" />
> > >CGM file is clear text, should be binary
> > >
> > >aciEdgeAtt aci file OK
> > >CGM file is clear text, should be binary
> > >
> > >aciFontNormalization aci file <fontmap> and </fontmap>
> > > should be <fontMap> and </fontMap>
> > >CGM file is clear text, should be binary
> > >
> > >Regards,
> > >Forrest
> > >
> > >
> > >-----Original Message-----
> > >From: Don Larson (E-mail) [mailto:dlarson@cgmlarson.com]
> > >Sent: Tuesday, March 17, 2009 9:02 AM
> > >To: Lofton Henderson
> > >Cc: CGM Open WebCGM TC
> > >Subject: re[2]: [cgmo-webcgm] review of aci files
> > >
> > >Lofton,
> > >
> > >All of the following ACI files have been updated by adding-
> > > <?xml version = "1.0" ?>
> > > <!DOCTYPE webcgmConfig SYSTEM "webConfig.dtd">
> > >
> > >
> > >aciFontNormalization
> > >aciGenericFonts
> > >aciMapListOrder
> > >aciLineAttr
> > >aciEdgeAttr
> > >aciLineEdgeTypeDef
> > >aciHatchStyleDef
> > >aciEdgeAttr.aci
> > >aciHatchStyleDef.aci
> > >aciLineAttr.aci
> > >aciLineEdgeTypeDef.aci
> > >aciMitreLimit.aci
> > >aciRestrictedTextType.aci
> > >
> > >Regards,
> > >Don L.
> > >Larson Software Technology
> > >www.cgmlarson.com
> > >
> > >
> > > > Don,
> > >
> > > > When you have corrected this, on every ACI file, could you please
> > inform
> > > > the TC via the TC list?
> > >
> > > > Then I'll update the matrix and we'll be ready for final steps
>toward
> > TC
> > > > "Approved".
> > >
> > > > Thanks,
> > > > -Lofton.
> > >
> > > > At 02:57 PM 3/16/2009 -0500, Forrest Carpenter wrote:
> > >
> > > > Lofton,
> > > >
> > > > None of the aci files in the test suite are valid xml files. Don
>has
> > > > corrected one error I pointed out in his latest update but all aci
> > files
> > > > in the test suite are missing the two lines below, the first line
>is
> > > > required and the second line should be included
> > > >
> > > > <?xml version = "1.0" ?>
> > > > <!DOCTYPE webcgmConfig SYSTEM "webConfig.dtd">
> > > >
> > > > Regards,
> > > > Forrest
> > > >
> > > >
> > > >
> > > >
> > > >
> > > > From: Lofton Henderson [mailto:lofton@rockynet.com]
> > > > Sent: Monday, March 16, 2009 1:33 PM
> > > > To: Forrest Carpenter; 'WebCGM'
> > > > Subject: Re: [cgmo-webcgm] review of aci files
> > > >
> > > >
> > > >
> > > > Forrest,
> > >
> > > > At 09:41 AM 3/10/2009 -0500, Forrest Carpenter wrote:
> > >
> > > >
> > > > I don t believe the aci files provided in the tests are valid. I
>have
> > > > attached an example of what I believe the files should look like.
>I
> > have
> > > > also found one error in the DTD, dashlength should be changed to
> > > > dashLength.
> > > >
> > > >
> > > > Can you be specific, what files you are referring to? I.e., list
> > them?
> > > > You had the Action to review these 7:
> > >
> > > > aciFontNormalization
> > > > aciGenericFonts
> > > > aciMapListOrder
> > > > aciLineAttr
> > > > aciEdgeAttr
> > > > aciLineEdgeTypeDef
> > > > aciHatchStyleDef
> > >
> > > > Does your comment apply to all 7 of these?
> > >
> > > > Then Don sent an update message saying he had updated this
>different
> > set
> > > > of files:
> > >
> > > > aciEdgeAttr.aci
> > > > aciHatchStyleDef.aci
> > > > aciLineAttr.aci
> > > > aciLineEdgeTypeDef.aci
> > > > aciMitreLimit.aci
> > > > aciRestrictedTextType.aci
> > >
> > > > I'm getting a little lost, trying to track the status of "Review"
>or
> > > > "Reworking", and who has the action item, in the matrix.
> > >
> > > > -Lofton.
> > >
> > >---------------------------------------------------------------------
[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]