Blank enumerations on attributes - e.g. Source@Role

["David RR Webber \(XML\)" <david@drrw.info>]

I've noticed we have a blank enumeration value defined.

 

I think this is generally bad practice.  I'd suggest that it is better to either make the item optional, or add an explicit value to cover off the "other" scenarios, or removing the blank value entirely.

 

So in case of Role we have:

 

'next receiver' , 'previous sender' , 'receiver' , 'sender' ,''

 

as values - whereas replacing the '' with 'other' - may provide better clarity - or just removing it - and requiring people pick a value.

 

Thanks, DW