Re: [kmip] Issue with test case TC-DLOGIN-1-20, Query operation needs a query function

[Mark Joseph <mark@p6r.com>]

Yup I used operations when I wrote this test case.    

Best,

Mark Joseph

P6R,  Inc

408-205-0361

mark@p6r.com

On Dec 21, 2018, at 5:38 PM, Anthony Berglas <anthony.berglas@cryptsoft.com> wrote:

Hmm.  I think the spec is wrong on this one, did not realize.  If you can ask for a number of things and you ask for none of them you should get nothing.  Bit like zero length strings.

That said, the spec is harder to change than the XML, so let's just make it Operations.

Anthony

On Sat, Dec 22, 2018 at 5:35 AM Mark Joseph <mark@p6r.com> wrote:

All the Query requests in this test have no query functions, yet if you look at the KMIP spec the request payload has

QueryFunction        Required -- Yes, May be Repeated,

So this test needs to be modified to include at least one query function??

I have not looked at the other Login tests yet do they do the same thing?

From the test case

# Request 2

<RequestMessage>

  <RequestHeader>

    <ProtocolVersion>

      <ProtocolVersionMajor type="Integer" value="2"/>

      <ProtocolVersionMinor type="Integer" value="0"/>

    </ProtocolVersion>

    <Authentication>

      <Credential>

        <CredentialType type="Enumeration" value="Ticket"/>

        <CredentialValue>

          <Ticket>

            <TicketType type="Enumeration" value="Login"/>

            <TicketValue type="ByteString" value="$TICKET_VALUE"/>

          </Ticket>

        </CredentialValue>

      </Credential>

    </Authentication>

    <BatchCount type="Integer" value="1"/>

  </RequestHeader>

  <BatchItem>

    <Operation type="Enumeration" value="Query"/>

    <RequestPayload>

    </RequestPayload>

  </BatchItem>

</RequestMessage>

Best,

Mark Joseph

P6R, Inc

408-205-0361

--

Anthony Berglas Ph.D.
Principal Engineer
Anthony.Berglas@Cryptsoft.com