[OASIS Issue Tracker] Commented: (MQTT-33) Trivia relating to WD04 Connect

[OASIS Issues Tracker <workgroup_mailer@lists.oasis-open.org>]

    [ http://tools.oasis-open.org/issues/browse/MQTT-33?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=33871#action_33871 ] 

Rahul Gupta commented on MQTT-33:
---------------------------------

Edited following lines in WD-05
-----------------------------------------------


1) Line 615

Variable header for CONNECT control packet consists of four fields. In the order in which they appear, they are Protocol Name, Protocol Version, Connect Flags, and Keep alive timer.

2) line 648

The Connect flags byte contains a number of parameters specifying the behavior of the MQTT connection. It also indicates the presence or absence of fields in the payload.

3) line 674

•	The client MAY store QoS=0 messages for transmission after the connect packet has flowed.

line 697

using QoS=1 or QoS=2.

4) line 677

•	The client subscriptions which it has acknowledged.

5) line 694

will not receive old publications and has to subscribe afresh to any topics that it is interested in each time it connects

6) line 701

for reliable messaging use QoS=1 or QoS=2 with cleanSession=0.

7) line 731

The value of Will QoS can be 0 (0x00), 1 (0x01), or 2 (0x02). The server is not required to validate the Will QoS if the Will flag is 0.

8) line 737

The Will Retain flag has no meaning if the WillFlag is 0.

9) line 740-741

if 1, the server MUST publish any will message on behalf of the client as a retained publication.
If 1, the server MUST publish any will message on behalf of the client as a non-retained publication. 



10) line 788 - 789

If a client does not receive a PINGRESP packet within a further Keep Alive time period after sending a PINGREQ, it SHOULD close the TCP/IP socket connection.

11) line 728  --- If the Will flag is set (1), thw will QoS
    line 833  --- If  Will Flag is set (1), then Will Topic is the next field in payload.
    line 849  --- If the Will Flag is set (1), Will Message is the next field in payload
    line 859  --- If the User Name Flag is set (1), this is the next field in payload. 
    line 866  --- If the Password flag is set (1), 
    line 868  --- If the Will flag is set (1), the Will QoS 

> Trivia relating to WD04 Connect
> -------------------------------
>
>                 Key: MQTT-33
>                 URL: http://tools.oasis-open.org/issues/browse/MQTT-33
>             Project: OASIS Message Queuing Telemetry Transport (MQTT) TC
>          Issue Type: Improvement
>          Components: edits
>            Reporter: Peter Niblett
>            Priority: Trivial
>
> 1. Line 519.  Section 3.1.2 should start by saying that the Variable Header for CONNECT consists of  four fields. In the order in which they appear, they are  Protocol Name, Protocol Version, Connect Flags, and Keep alive timer.
> 2. Line 541.  "The connect flags indicate the presence or absence of fields in the payload and QoS of any Will Message".  There are several problems with this sentence
> Replace with "The Connect Flags byte contains a number of parameters specifying the behavior of the MQTT connection.  It also indicates the presence or absence of fields in the payload." 
> 3. Lines 565 and 588 Qos -> QoS
> 4. Line 568 clients -> client
> 5. Line 585 has normative word SHOULD in a non-normative comment. I would suggest saying "..will not receive old publications and has to subscribe afresh to any topics that it is interested in each time it connects"
> 6. Line 587 "achieves reliable messages" doesn't sound like good English.  Replace the sentence with something like  "For reliable messaging, use QoS=1 or QoS=2 with cleanSession=0".
> 7. Line 607. "The value of Will QoS is 0..." -> "The value of Will QoS can be 0.."
> 8. Line 613  "WillRetain" -> "Will Retain"
> 9. Lines 615..617 describe the meaning of Will Retain.   T
> The old words in 3.1 were
> "The Will Retain flag indicates whether the server should retain the Will message which is published by the server on behalf of the client in the event that the client is disconnected unexpectedly." which seem reasonably clear to me
> The words in WD04 are 
> "If 0, any will message published by the server on behalf of the client MUST NOT be a retained publication. 
> "If 1, any will message published by the server on behalf of the client MUST be a retained publication. 
> I think the MUST be reads strangely. 
> I guess the reason for rewording was to avoid duplicating the definition of Retain. If so I would prefer
> "If 1, the server MUST publish any will message on behalf of the client as a retained publication." 
> "If 1, the server MUST publish any will message on behalf of the client as a non-retained publication." 
> To be pedantic you then need to define the terms retained and non-retained in section 2.1.2.3
> 10. Line 656.  "should" -> "SHOULD"
>  

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://tools.oasis-open.org/issues/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira