[OASIS Issue Tracker] Commented: (MQTT-37) Editorial comments on 3.3 (Publish)

[OASIS Issues Tracker <workgroup_mailer@lists.oasis-open.org>]

    [ http://tools.oasis-open.org/issues/browse/MQTT-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=34114#action_34114 ] 

Rahul Gupta commented on MQTT-37:
---------------------------------

1) Deleted line - The topic name is a hierarchical name space for which subscribers can register an interest

2) line 746 - 748 : The PUBLISH packet contains a topic name. The topic names used in publications MUST NOT contain wildcard characters. The topic names used in subscriptions can be generic, in that they can contain wildcard characters. 

3) line 741 - A PUBLISH control packet is sent by a MQTT publisher to a MQTT server or from MQTT server to MQTT subscriber, for distributing publications to interested subscribers. If a subscriber subscribes to one or more topics, any publication published to those topics MAY be sent by the server to the subscriber using a PUBLISH packet.

4) Line 746 - The PUBLISH control packet contains a topic name. The topic names used in publications MUST NOT contain wildcard characters. However the topic names used in subscriptions can be generic, in that they can contain wildcard characters. 

5) In fixed header example of PUBLISH control packet.
   DUP = 0
   QOS = 01
   Retain = 0

6) Line 761: Set to zero (0). This means do not retain the publication. See Retain section 2.1.2.3 for more details.

7) line 775: The variable header contains the following fields in the order given here:

8) line 781: The Topic name MUST be a UTF-8 encoded string as defined in section 2.1.3. It can be up to 65535 bytes long.. 

9) line 782:  The topic name MUST NOT contain wildcard characters

10) line 791 : Cell deleted with QoS=1


> Editorial comments on 3.3 (Publish)
> -----------------------------------
>
>                 Key: MQTT-37
>                 URL: http://tools.oasis-open.org/issues/browse/MQTT-37
>             Project: OASIS Message Queuing Telemetry Transport (MQTT) TC
>          Issue Type: Improvement
>          Components: edits
>            Reporter: Peter Niblett
>            Priority: Minor
>
> 1. Line 763 has the sentence "The topic name is a hierarchical name space for which subscribers can register an interest".  A name isn't a name space and the thing that people register interest in doesn't have to be the name that appears in the PUBLISH message. Since there's a discussion of topics and matching elsewhere, I suggest we don't need this sentence at this point and it can be deleted.
> 2. Line 764 has "A message that is published to a specific topic name is delivered to subscribers for that topic". "Specific" is an unfortunate word since it suggests "non-wildcarded" and all messages have to be published to  non-wildcarded. I think it just means "any given topic". However more seriously we shouldn't be stating tha the message "is delivered to subscribers" since they might not be there, or we might choose to expire the message or not deliver it for security reasons. Again I suggest deleting it. 
> 3. Similarly in line 767 there's an implication that any message published to the server on a given topic will be delivered to subscribers to that topic. I would just rephrase this paragraph to say "The PUBLISH control packet is also used to send messages from the server to the client."
> 4. The sentence in line 770 about wildcard subscriptions isn't relevant here and can be deleted. The second sentence should say "The topic name in a PUBLISH control packet MUST NOT contain wildcard characters".  However you have almost the same sentence at 880, so I am not sure you need it twice.
> 5. The table showing the fixed header format has 0 rather than X for DUP and RETAIN, which implies that these two flags can never be set to 1. They should be X
> 6. Line 783 says that the RETAIN flag means "do not retain". This sentence should be deleted.
> 7. Line 791 should say "The variable header contains the following fields in the order given here:"
> 8. Line 806 says "The Topic name MUST be a String which can be encoded as UTF-8".  It has to be encoded as UTF-8. We should use a consistent set of words here across all the places where strings occur, e.g. "The Topic Name is a UTF-8 encoded string as defined in section 2.1.3. It can be up to 65535 bytes long".
> 9. Line 807 "MUST not" -> "MUST NOT"
> 10. Line 813 (see issue 31)  says that the MessageId field is only present if QoS>0 , but then goes on to say that for QoS=0 the MessageId MUST be 0. We need to clarify whether the bytes are physically there or not when QoS=0.
> 10. The table in line 820 shows a QoS level, but QoS goes in the Fixed Header not the Variable header so this row should be deleted. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://tools.oasis-open.org/issues/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira