[OASIS Issue Tracker] (MQTT-239) Question regarding use of byte in Connack packet (review comment from Nicholas Humfrey)

[OASIS Issues Tracker <workgroup_mailer@lists.oasis-open.org>]

    [ https://issues.oasis-open.org/browse/MQTT-239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=44542#comment-44542 ] 

Richard Coppen commented on MQTT-239:
-------------------------------------

Closed TC call 21.08.2014:
Misunderstanding of the specification. See email exchange with Nicolas and Roger on mqtt-comments list

> Question regarding use of byte in Connack packet (review comment from Nicholas Humfrey)
> ---------------------------------------------------------------------------------------
>
>                 Key: MQTT-239
>                 URL: https://issues.oasis-open.org/browse/MQTT-239
>             Project: OASIS Message Queuing Telemetry Transport (MQTT) TC
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 3.1.1
>            Reporter: Richard Coppen
>
> Public review comment received from Nicholas Humfrey (point 2)
>  
> 2) I was quite surprised to discover that an additional byte had been inserted in front of the return code byte in the Connack packet type, making it harder to maintain backwards compatibility. Given that the fixed header flags have now been made specific to the packet type, what was the reason for not using one of those? It seems like an expensive break in the existing protocol for a minor new feature? Particularly when there has been effort to preserve other less useful features of the protocol, such as setting flag bit 1 in the fixed header of a Subscribe packet.
> Roger Light responded to this post, clarifying as follows:
> The byte in question containing the "session present" flag just
> replaces the already existing "reserved" byte of the CONNACK packet,
> so there is no break in compatibility.



--
This message was sent by Atlassian JIRA
(v6.2.2#6258)