OASIS Mailing List ArchivesView the OASIS mailing list archive below
or browse/search using MarkMail.

 


Help: OASIS Mailing Lists Help | MarkMail Help

office message

[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]


Subject: review ODF 1.2 specification draft - chapter 18,attributes in fo namespace


Dear TC members,

I have reviewed the attributes in the fo namespace in chapter 18 of our
current ODF 1.2 specification draft.

Here are my comments:
- General
-- I am not sure, if it is good to have only the reference to XSL for
attributes in fo namespace. Below, you will find some comments to
include some sentence about the attribute's purpose. After given such
comments to the first reviewed attributes I omit them for the rest and
write down this general comment. I think we should decide, if a
reference to XSL is enough for such attributes or if some text about the
purpose of such attributes for ODF should be added.

- "18.402 fo:background-color"
-- Replace the two "ref-element-..." text snippets by the corresponding
reference.
-- Reference to XSL is missing. The former reference to XSL can be found
in the ODF 1.2 specification draft 6 in sub chapters 16.4.37 and 16.5.23
-- 3rd paragraph: Integrate that this statement for paragraph also holds
for page, header, footer and section.
-- 4th paragraph: Integrate that this statement for table and cell also
holds for row.
-- 5th paragraph: Indicate that this statement holds for table, cell and
row.
-- Include paragraph which contains statement for frame regarding
background according to ODF 1.2 specification draft 6, sub chapter 16.27.18
-- Generated section from schema contains twice the statement about the
elements the attribute is used with.

- "18.403.1 General"
-- content of first bullet item has to be <style:graphic-properties>
-- Probably, we can remove the bullet list and replace it by some text
like "... specify border properties for page, header/footer, paragraph,
cell and frame." Information about the elements the attributes may be
used with is already given in the generate section.

- "18:404 fo:break-after" and "18.405 fo-break-before"
ad Ed. Note: I do not think that we support value "inherit". The value
was not in the schema fragments in the ODF 1.2 specification draft 6.
Thus, I think we should add this to the paragraph, which already state
that we do not support value "odd-page" and "even-page".

- "18.406 fo:clip"
-- I have no answers for the two editor notes.
-- It seems that we also does not support value "inherit".
--> a lot of questions/remarks. Thus, this attribute sub chapter is
somehow in status "red" from my point of view.

- "18.407 fo:color"
-- Please include a sentence like "The fo:color attribute specifies the
foreground color of text."
-- ad Ed. Note 1: I do not know, if we want switch to XSL 1.1. But, if
we switch, all XSL references need to be adjusted.
-- ad Ed. Note 2: Yes, it seems that we do not support value "inherit".
Thus, we have to state it explicitly.

- "18.408 fo:column-count" and "18.409 fo:column-gap"
I have got no solution for the remarks in the editor's notes.

- "18.410 fo:country"
-- Relation to fo:language: fo-country may be ignored if it is not
specified together with fo:language attribute.
-- ad editor's note: Yes, it seems we do not support value "none" and
"inherit". Thus, we have to state it explicitly.
-- Include a paragraph, which states that this attribute specifies the
country of a text for its usage in element <style:text-properties>.
-- Include a paragraph, which describes that fo:country and fo:language
are also used to further define sorting algorithms - see ODF 1.2
specification draft 6, sub chapters 7.8.1, 7.8.1.8 and 15.10.3.3 - for
its usage in elements <text:alphabetical-index-source> and
<text:bibliography-configuration>.

- "18.411 fo:end-indent"
-- Include statements (taken from ODF 1.2 specification draft, sub
chapter 16.7.4.2). Probably, we should include this information at
element <style:column>:
--- that this attribute specifies the right space of a column,
--- that this attribute together with the left space (fo:start-indent)
of the following column corresponds to the gap between these columns and
--- that the width of an existing separator line between these columns
is included in these spaces.
-- Question: is the reference to XSL ok? We did not have it in ODF 1.2
specification draft 6.

- "18.412 fo:font-family"
-- Include statements (taken from ODF 1.2 specification draft 6, sub
chapter 16.4.14)
--- that the attribute specifies the font family of a text and
--- that this attribute can be used instead of the style:font-name
attribute, but usage of style:font-name is recommended.
-- Generated text contains twice the statement about the element with
which the attributes may be used.

- "18.413 fo-font-size"
-- 3rd paragraph does not belong to this attribute - it more belongs to
fo:font-family.
-- Information about values given in ODF 1.2 specification draft 6, sub
chapter 16.4.19 is completely missing.
-- We should explicitly state which attribute values from XSL we do not
support.
-- I do not think that this attribute should be deprecated.

- "18.414 fo:font-style"
-- We should explicitly state which attribute values from XSL we do not
support.

- "18.415 fo:font-variant"
-- ad 1st editor's note: see my comment above - 18.407
-- ad 2nd editor's note: not supported values from XSL should be
explicitly named.
-- ad 3rd editor's note: I have no solution. --> status "red"

- "18.417 fo:height"
-- Include statement that this attribute specifies the height of the
bullet image in a certain list level definition.
-- ad editor's note:
--- explicitly name not supported XSL attribute values.
--- I do not know, if this attribute is only used for specifying the
size of a bullet image. Action item for me: check it in OpenOffice.org.

- "18.418 fo:hyphenate"
-- ad editor's note:
--- Yes, we have to explicitly state that we do not support value "inherit".
--- No answer from my side to the other questions in the editor's note.
I think these question are also for the other fo:hyphenation-...
attributes. Right?

- "18.419 fo:hyphenation-keep"
-- Explicitly state that we do not support values "column" and "inherit".

- "18.420 fo:hyphenation-ladder-count"
-- Explicitly state that we do not support value "inherit".

- "18.421 fo:hyphenation-push-char-count"
-- Default value can not be 0, because the value type of this attribute
is "positiveInteger", which does not include 0. XSL states that its
value is of type "integer" and that negative and non-integer values are
mapped the nearest integer greater than 0.
Possible solutions:
- change type of attribute to "nonNegativeInteger" or
- change default value.
-- Explicitly state that we do not support value "inherit".

- "18.422 fo:hypenation-remain-char-count"
-- [the same as for fo:hypenation-push-char-count - see above]

- "18.423 fo:keep-together"
-- Please state that this attribute is used for paragraphs and table rows.
-- Yes, state that we do not support value "inherit" and integer values.

- "18.424 fo:keep-with-next"
-- Reference to XSL is wrong. It has to be "7.19.4", not "7.9.14".

- "18.425 fo:language"
-- Yes, we do not support values "none" and "inherit".
-- The "corresponding" comes in due to copy-and-paste from original
section, in which also style:language-asien and style:language-complex
are specified. IMHO it can be removed. Thus, fo:country and fo:language
"go together". The same is hold for style:country-asien and
style:language-asien. And for style:country-complex and
style:language-complex, too.
-- Include a paragraph, which describes that fo:country and fo:language
are also used to further define sorting algorithms - see ODF 1.2
specification draft 6, sub chapters 7.8.1, 7.8.1.8 and 15.10.3.3 - for
its usage in elements <text:alphabetical-index-source> and
<text:bibliography-configuration>.

- "18.426 fo:letter-space"
-- Yes, we do not support values "space" and "inherit".

- "18.427 fo:line-height"
-- 2nd setences of 1st paragraph should be removed. It is the same as
the 2nd paragraph.
-- Yes, we do not support values "number", "space" and "inherit".

- "18.428 fo:margin"
-- Yes, we should state that we do support only one value, which can be
a length or a percentage. A percentage is relative to the parent style's
margin - like it is for the other fo:margin-... attributes.

- "18.429 fo:margin-bottom"
-- Yes, we do not support value "auto" and "inherit".
-- Yes, in general we do not support value "inherit" from XSL
attributes, but for value "auto" I do not think this is true - see
fo:keep-together and fo:hyphenation-keep.
-- For a percentage value we should state that the bottom margin value
is the given percent value of the parent style's bottom margin value.
-- Information is missing that a percentage value is not supported for
<style:graphic-properties> - see sub chapter "16.27.5 Top and Bottom
Margins" of ODF 1.2 specification draft 6.
-- Information is missing that for page footers attribute
fo:margin-bottom is ignored - see sub chapter "16.3.2 Margins" in ODF
1.2 specification draft 6.

- "18:430 fo:margin-left"
-- Information is missing that a percentage value is not supported for
<style:graphic-properties> - see sub chapter "16.27.5 Left and Right
Margins" of ODF 1.2 specification draft 6.
-- Percentage value for section also does not make sense - see sub
chapter "15.7.2 Margins" in ODF 1.1 specification. Or do we changed this
for ODF 1.2 - I did not find a corresponding proposal.
-- The second and third paragraph should be removed. They should be
integrated into element <style:list-level-label-alignment>. For
<style:list-level-lable-alignment> percentage values does not makes
sense and need to be excluded. -> I have given me an action item to
provide the corresponding text.
-- 5th paragraph about fo:text-indent can be removed in my opinion - it
is already present at attribute fo:text-indent.
-- In last paragraph the information about right margin in tables should
be removed.
-- For a percentage value we should state that the left margin value is
the given percent value of the parent style's left margin value.
-- Question to the schema experts: Can the schema assure certain value
types in certain elements? Than we do not have to state in prose that in
certain elements percentage values are not supported.

- "18.430.1 fo:margin-right"
-- This sub chapter should be a sub chapter of chapter "18 Attributes".
-- Information is missing that a percentage value is not supported for
<style:graphic-properties> - see sub chapter "16.27.4 Left and Right
Margins" of ODF 1.2 specification draft 6.
-- Percentage value for section also does not make sense - see sub
chapter "15.7.2 Margins" in ODF 1.1 specification. Or do we changed this
for ODF 1.2 - I did not find a corresponding proposal.
-- 3th paragraph about fo:text-indent can be removed in my opinion - it
is already present at attribute fo:text-indent.
-- In last paragraph the information about left margin in tables should
be removed.
-- Yes, list item does not have a right margin via its list level
properties, which are applied via the list style.

- "18.431 fo:margin-top"
-- Yes, we do not support value "auto" and "inherit".
-- For a percentage value we should state that the top margin value is
the given percent value of the parent style's top margin value.
-- Information is missing that for page headers attribute fo:margin-top
is ignored - see sub chapter "16.3.2 Margins" in ODF 1.2 specification
draft 6.

- "18.432 fo:max-height"
-- In ODF 1.2 draft 6 and ODF 1.1 we had no reference to XSL. What was
the reason to include it? Was it intention not to have it or was it a
defect?

- "18.433 fo:max-width"
-- In ODF 1.2 draft 6 and ODF 1.1 we had no reference to XSL. What was
the reason to include it? Was it intention not to have it or was it a
defect?

- "18.434 fo:min-height"
-- In ODF 1.2 draft 6 and ODF 1.1 we had no reference to XSL. What was
the reason to include it? Was it intention not to have it or was it a
defect?
-- 1st paragraph should also state that it specifies the minimum height
of a text box.
-- It should also be stated that the attribute specifies the minimum
height of a header or a footer - see sub chapter "16.3.1 Fixed and
Minimum heights" in ODF 1.2 draft 6
-- Ad editor's note: It is meant that svg:height specifies the fixed
height for a header or footer, while fo:min-height specifies the minimum
height for a header or a footer, in my honest opinion.

- "18.435 fo:min-width"
-- In ODF 1.2 draft 6 and ODF 1.1 we had no reference to XSL. What was
the reason to include it? Was it intention not to have it or was it a
defect?
-- Ad editor's note: svg:height specifies the height of a text box,
while fo:min-width specifies the minimum width of a text box, in my
honest opinion.

- "18.436 fo:orphans"
-- We do not support value "inherit".
-- We strict the attribute for paragraph orphans.

- "18.437 fo:page-height"
-- We only support value type "length"

- "18.438 fo:page-width"
-- We only support value type "length"

- "18.439 fo:padding"
-- We only support one value of type "NonNegativeLength"

- "18.440 fo:padding-bottom" till "18.443 fo:padding-top"
-- We do not support value "inherit"

- "18.444 fo:space-after" and "18.445 fo:space-before"
-- In ODF 1.2 draft 6 and ODF 1.1 we had no reference to XSL. What was
the reason to include it? Was it intention not to have it or was it a
defect?
-- We restrict its usage to a column.
-- We do not support value "inherit".

- "18.446 fo:start-indent"
-- In ODF 1.2 draft 6 and ODF 1.1 we had no reference to XSL. What was
the reason to include it? Was it intention not to have it or was it a
defect?
-- We restrict its usage to a column.

- "18.447 fo:text-align"
-- Include statement that this attribute is used for alignment of
paragraphs and the alignment of list labels.
-- Move information of 2nd paragraph, the following enumeration and the
3rd paragraph to element <style:list-level-properties> -> I have given
me an action item to provide the corresponding text.
-- Add information to 4th paragraph that this is hold for the alignment
of paragraphs.

- "18.449 fo:text-indent"
-- ad editor's note: I will provide some text about it for element
<style:list-level-label-alignment>. Here we should only add at the end
of the 1st sentence the text "or a list item".

- "18:451 fo:text-transform"
-- Question: Is it really deprecated? I did not find the corresponding
proposal.

- "18.452 fo:widows"
-- We do not support value "inherit".
-- We strict the attribute for paragraph widows.

- "18.453 fo:width"
-- In ODF 1.2 draft 6 and ODF 1.1 we had no reference to XSL. What was
the reason to include it? Was it intention not to have it or was it a
defect?
-- We restrict its usage to the image of the list label, as far as I can
see.

- "18.454 fo:wrap-option"
-- I am not familar with this attribute. Thus, the status of this
attribute is somehow "red".


Best regards, Oliver.

-- 
=======================================================================
Sun Microsystems GmbH    Oliver-Rainer Wittmann
Nagelsweg 55             Software Engineer - OpenOffice.org/StarOffice
20097 Hamburg
Germany                  Fax:   (+49 40) 23 646 955
http://www.sun.de        mailto:oliver-rainer.wittmann@sun.com
-----------------------------------------------------------------------
Sitz der Gesellschaft:
Sun Microsystems GmbH, Sonnenallee 1, D-85551 Kirchheim-Heimstetten
Amtsgericht Muenchen: HRB 161028
Geschaeftsfuehrer: Thomas Schroeder, Wolfgang Engels, Dr. Roland Boemer
Vorsitzender des Aufsichtsrates: Martin Haering

=======================================================================
Oliver-Rainer Wittmann (od) - OpenOffice.org Writer
OpenOffice.org Engineering at Sun: http://blogs.sun.com/GullFOSS


[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]