OASIS Mailing List ArchivesView the OASIS mailing list archive below
or browse/search using MarkMail.

 


Help: OASIS Mailing Lists Help | MarkMail Help

office message

[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]


Subject: [Fwd: Re: Review of ODF 1.2 specification draft 7]


Hi TC members,

below you will find further review results of my colleague Micheal Stahl:

18.535 meta:name

<quote>
The meta:name attribute specifies the name of a metadata element.
</quote>

maybe we should say "user-defined metadata element"?
also, what about "the unique name"?

also, it is apparently legal to use an empty attribute like:
<meta:user-defined meta:name=""/>
i believe such a use is not intended.
is it possible to forbid empty meta:name?


18.1114 table:automatic-find-labels

in a previous review i claimed:
"this should be text:automatic-find-labels"
but actually, it is a table attribute, it is just not sorted correctly.


18.1175 text:list-id

<quote>
A numbered paragraph that does not have a text:list-id gets the
text:list-id of the last numbered paragraph on the same list level using
the same list style. If the previous numbered-paragraph has a different
list style, then a new list is started.
</quote>

it is my understanding that if the previous numbered-paragraph is on a
higher level (text:level) than this numbered-paragraph, then a new list
should be started as well, instead of continuing a list on the same level
that was before the previous numbered-paragraph.
if this is indeed intended, maybe it should be explicitly mentioned.

<quote>
A numbered paragraph can be assigned a list level. A numbered paragraph is
equivalent to a list nested to the given level, containing one list item
with one paragraph. If no level is given, the numbered paragraph is
interpreted as being on level 1.
</quote>

this probably belongs to the list level attribute description.

<quote>
As a numbered paragraph combines the functionality of a (possibly nested)
list with a single list item, it can also use the following attributes of
those elements.
</quote>

this belongs to the description of numbered-paragraph element.

<quote>
If a list style is not specified for a numbered paragraph, the list style
of the previous numbered paragraph in the same sublist is used. If this
paragraph is the first in the sublist, the list style of the previous
paragraph in the higher list level is used. If there is no such style
available, a default style is applied. This is the same default list style
as the one mentioned in section .
If a list level style is missing in the applied list style of a numbered
paragraph, the same rules are applied to determine this list level style
as for list items.
<quote>

this belongs to the description of text:style-name attribute.

<quote>
The text of a formatted number can be included in a <text:number> element.
Note: This text can be used by applications that do not support numbering.
<quote>

this belongs to the description of numbered-paragraph element.


18.1183 text:name

all the elements are not formatted as elements

also, i have to wonder again whether text:name="" should be allowed.

<quote>
* <text:bookmark-start>, <text:bookmark-end>, <text:bookmark> - specifies
matching names for the bookmarks. <text:bookmark>
</quote>
                                   ^^^^^^^^^^^^^^^ ???

i would prefer something like this:

"specifies a unique name for the bookmark, or, in the case of the
<text:bookmark-end> element, specifies the matching start element by name."

<quote>
* <text:variable-set> - specifies name that must match name already 
declared.
</quote>

i prefer what draft6 had:

<quote>
specifies the name of the variable to set. It must match the name of a
variable that has already been declared.
</quote>

and similarly for the rest of the list.

also, the following text from draft6, which i could not find in the new
draft, suggests that variable, user-field and sequence share one namespace:

<quote>
The name must be unique. It cannot already be used for any other type of
variable including simple and sequence variables.
</quote>

hmm... what about the following:

"* <text:variable-decl>, <text:user-field-decl>, <text:sequence-decl> -
specifies the name of a simple variable, user field, or sequence variable,
respectively. The name must be unique, and all three types of variables
share the same namespace.
* <text:variable-set>, <text:variable-get>, <text:variable-input>,
<text:user-field-get>, <text:user-field-input>, <text:sequence> -
references a previously declared simple variable, user field, or sequence
variable, respectively, by its unique name."


18.1189 text:outline-level

all the elements are not formatted as elements.

<quote>
* <text:toc-mark-start> - specifies he outline level
</quote>
                                     ^^ the
<text:toc-mark> should also be listed at this item.


<text:user-index-mark> and <text:user-index-mark-start> are not described
at all. maybe add something like this:

"* <text:user-index-mark>, <text:user-index-mark-start> - specifies the
outline level of the resulting user-defined index entry."


why does <text:user-index-mark-end> have this attribute in the schema?
this seems like an error to me...


<quote>
* <text:index-sources-styles> - specifies the outline level to use. The
<text:index-entry-chapter> element displays the chapter number up to the
specified outline level. If the outline level attribute is missing, it's
assumed that it equals the outline level, at which the source of the entry
occurs in the text document.
</quote>

this looks like 2 items in one...

<quote>
level, at which the source of the entry occurs in the text document.
</quote>
      ^ spurious comma

draft6 had this text for index-sources-styles:

<quote>
The text:outline-level attribute determines at which outline level to list
the index entries gathered from the respective paragraph styles.
</quote>


18.1190.1 text:page-adjust

this is the same as 18.1190 text:page-adjust???


18.1193 table:precision-as-shown

waiter, there's a fly in my text attributes!


18.1203 text:section-name

<quote>
The text:section-name attribute
</quote>
     ^^^^^^^^^^^^^^^^^ is not formatted as attribute


18.1204 text:select-page

<quote>
* <text:page-continuation>
</quote>
   ^^^^^^^^^^^^^^^^^^^^^^^^ not formatted as element
<quote>
* <text:page-number>
</quote>
   ^^^^^^^^^^^^^^^^^^ not formatted as element


18.1209 text:space-before

<quote>
This attribute can be associated with an formatting properties element
</quote>
                                       ^^ a
<quote>
This means that when the position of a label is calculated the start
indent value of the current level is only considered.
</quote>
shouldn't the "only" come after "calculated", maybe with a comma?


18.1210 text:start-value

* <text:numbered-paragraph>

this should do the same thing as for <text:list-item>, i.e., restart the
numbering of the list at this item/numbered-paragraph.


18.1212 text:string-value-phonetic

<quote>
The text:string-value-phonetic attribute
</quote>
     ^^^^^^^^^^^^^^^^^^^^^^^^^^ is not formatted as attribute


18.1213 text:string-value

a description for <text:toc-mark>, <text:alphabetical-index-mark>,
<text:user-index-mark> is missing. draft6 had this to say (similarly for
the other indexes):

<quote>
Table of contents index marks also have a variant that does not enclose
the text to be indexed. This is represented using the <text:toc-mark>
element which contains a text:string-value attribute for the text of the
index entry.
</quote>


18.1216 text:style-name

the description for <text:numbered-paragraph> is at the text:list-id
attribute.

<quote>
* <text:section> -
</quote>

the following are missing from this list item:
<text:index-title>, <text:table-of-content>, <text:illustration-index>,
<text:table-index>, <text:object-index>, <text:user-index>,
<text:alphabetical-index>, <text:bibliography>

<quote>
* <text:a> - specifies a style for an unvisited hyperlink. (no restrictions)
</quote>

draft6 claims this must be a text style:

<quote>
If the link location of the hyperlink was not visited, the text style
specifies[sic] by the text:style-name attribute is applied to the text of
the hyperlink.
</quote>

a description for <text:ruby-text> is missing. draft6:

<quote>
The element's text:style-name attribute references a text style that
specifies further formatting attributes used for the text.
</quote>

<quote>
* <text:table-of-content-entry-template>,
<text:illustration-index-entry-template> ...
</quote>

the following are missing from this list item:
<text:object-index-entry-template>, <text:table-index-entry-template>


18.1223 text:time-value

<quote>
The text:time-value attribute
</quote>
     ^^^^^^^^^^^^^^^ is not formatted as attribute

<quote>
Applications may support date and time in addition to date-only values.
</quote>
                                                       ^^^^ time

actually, according to the schema this is true only for <text:time> and
<text:creation-time>; on the other hand, <text:modification-time> and
<text:print-time> specify just "time", not "timeOrDateTime". this is
rather inconsistent.


18.1224 text:track-changes

<quote>
The text:track-changes attribute
</quote>
     ^^^^^^^^^^^^^^^ is not formatted as attribute


18.1241 text:value

<quote>
The text:value attribute
</quote>
     ^^^^^^^^^^ is not formatted as attribute


18.1242 text:visited-style-name

maybe it should be mentioned that it is a text style


18.1243 xforms:bind

<quote>
The xforms:bind attribute specifies the binding of a OpenDocument control
</quote>
     ^^^^^^^^^^^ formatting
<quote>
to a defined XForm model. With buttons the bind attribute refers to an
</quote>
              ^^^^^ is there a singular, or should this be XForms?
<quote>
<xforms:submission> element with the given ID. Pushing the button causes
</quote>
^^^^^^^^^^^^^^^^^^^ formatting

<quote>
the appropriate XForms submission action to be performed. For all other
control types, the xforms:bind attribute
</quote>
                    ^^^^^^^^^^^ formatting

<quote>
refers to an <xforms:bind> element with the given ID.
</quote>
              ^^^^^^^^^^^^^ formatting


-- 
=======================================================================
Sun Microsystems GmbH    Oliver-Rainer Wittmann
Nagelsweg 55             Software Engineer - OpenOffice.org/StarOffice
20097 Hamburg
Germany                  Fax:   (+49 40) 23 646 955
http://www.sun.de        mailto:oliver-rainer.wittmann@sun.com
-----------------------------------------------------------------------
Sitz der Gesellschaft:
Sun Microsystems GmbH, Sonnenallee 1, D-85551 Kirchheim-Heimstetten
Amtsgericht Muenchen: HRB 161028
Geschaeftsfuehrer: Thomas Schroeder, Wolfgang Engels, Dr. Roland Boemer
Vorsitzender des Aufsichtsrates: Martin Haering

=======================================================================
Oliver-Rainer Wittmann (od) - OpenOffice.org Writer
OpenOffice.org Engineering at Sun: http://blogs.sun.com/GullFOSS


[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]