[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]
Subject: [OASIS Issue Tracker] Commented: (OFFICE-1584) Editor Note: Section17.127 draw:concave
[ http://tools.oasis-open.org/issues/browse/OFFICE-1584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12001#action_12001 ]
Dennis Hamilton commented on OFFICE-1584:
-----------------------------------------
1. The current text is the same in ODF 1.1 and ODF 1.0. Any clarification applies to all of the ODF versions.
2. Isn't it sufficient that this is only for draw:regular-polygon, with only one supported concave variations? I agree that the statement should not suggest that all regular concave polygons are supported.
According to Wikipedia, the construction can be described more simply, http://en.wikipedia.org/wiki/Regular_polygon
3. Since the draw namespace binding is for a unique ODF namespace, it would appear appropriate to provide a sharper definition. That definition could establish that the only supported conclave regular polygons are the regular simple star shapes.
BUG 1: (Major) I don't believe that the term "ellipse" is correct in the definitions of draw:conclave and draw:sharpness. It seems that "circle" is the correct term, since there is only one specified center point, and it is the geometric center of the regular figure. There does not seem to be enough information provided in attributes of <draw:regular-polygon> for it to be otherwise.
BUG 2: I agree that there are more concave regular polygons than the one described. It appears that only simple stars are intended (that would be a better name for the attribute) which means that alternating vertices are on the inner circle (which may have radius 0 when draw:sharpness="100").
BUG 3: (Minor) <draw:regular-polygon> talks about just stating the number of edges, but the attribute used to do this is draw:corners (!). Of course, when draw:sharpness is sufficiently close to 100, half of the corners will not be distinct.
BUG 4: (Intermediate) For draw:conclave="true" it seems useful to require the value of draw:corners to be an even number greater than 5. For draw:conclave="false" it seems useful to require the value of draw:corners to be greater than 2. I believe this should be a conformance requirement for ODF documents.
BUG 5: (Major) I can find no indication of the internal coordinate system that applies for a <draw:regular-polygon>. For example, is the common center the origin? Also, what is the radius of the outer circle or other way that it can be determined (by the coordinate of one of the outer corners)? Next, what is the position of some initial outer corner? Without this information, there is no way to understand the application of transformations to the shape. It is unclear how svg:height, svg:width, svg:x and svg:y interact with that geometry. It is also not clear how anchor alignment works without more information about the internal coordinate system of the shape, including what should be taken as a baseline, etc.
BUG 6. (Major) What are the default glue points that apply to a <draw:regular polygon>
BUG 7. (Major) Unqualified references to section 5.1.2 of [SVG] are entirely useless. Section 5.1.2 is a DTD fragment for an <svg:svg> element (more-or-less) and the only way to make sense of attributes such as x, y, width, and height (without prefix according to this DTD) is to establish the coordinate system of the element and its context. [SVG] does not do that for us. It is not enough to simply say "SVG-compatible" here.
[I ask these as questions without offering resolutiion because I simply have no idea what the intended or tacitly understood situation is meant to be.]
BLOCKER
> Editor Note: Section 17.127 draw:concave
> -----------------------------------------
>
> Key: OFFICE-1584
> URL: http://tools.oasis-open.org/issues/browse/OFFICE-1584
> Project: OASIS Open Document Format for Office Applications (OpenDocument) TC
> Issue Type: Bug
> Affects Versions: ODF 1.2
> Reporter: Robert Weir
> Assignee: Patrick Durusau
> Fix For: ODF 1.2
>
>
> Transcribed from ODF_Revised_Editorial_Notes_27May2009.odt
> Original author: Patrick Durusau
> Section 17.127 draw:concave
> Ed. Note While the explanation is correct for one class of concave polygons it is not correct for all. A polygon with one interior angle greater than 180 degrees is also a concave polygon. The draw:shapness attribute only enables the drawing of only one type of concave polygon. That's ok, but we need to say it is a limited class of polygons to which this applies.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://tools.oasis-open.org/issues/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]