OASIS Mailing List ArchivesView the OASIS mailing list archive below
or browse/search using MarkMail.

 


Help: OASIS Mailing Lists Help | MarkMail Help

office message

[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]


Subject: [OASIS Issue Tracker] Issue Comment Edited: (OFFICE-3758) The addition for draw:circle in 19.571.10 not clear


    [ http://tools.oasis-open.org/issues/browse/OFFICE-3758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=32993#action_32993 ] 

Regina Henschel edited comment on OFFICE-3758 at 4/14/13 9:39 AM:
------------------------------------------------------------------

I think, connecting svg:width to "bounding box" is wrong:
- For a draw:caption element I expect, that svg:width and svg:height give the size of the text area, but a draw:caption element has a line to its caption-point in addition. What is the "bounding box" then?
- A draw:custom-shape can have points, which are outside the viewbox and parts of the Bezier-curve for example, can be outside the viewbox too.
- If I use a draw:ellipse element of kind "section" I expect, that the radii and the center of the ellipse do not change, when I vary start- or end-angle.

19.571.10 references §5.1.2 of [SVG]. There it is "For embedded 'svg' elements, the width of the rectangular region into which the 'svg' element is placed." Besides the fact that there is no 'svg' element here, the word "into" is not usable, because parts of the shape can be outside, see above.

I suggest: "The attribute svg:width determines together with the attribute svg:height a rectangle, which is a reference for drawing the shape."

And then specify for the different kind of shapes, how this reference is used.

"For a draw:control, draw:frame, draw:rect or draw:page-thumbnail element this rectangle determines the size of the element directly.
A draw:circle element is scaled with keeping aspect ratio, so that the full circle fits into this rectangle, independent of the attribute draw:kind of the circle. The element is placed so that the full circle is centered in this rectangle.
A draw:ellipse element is scaled so that the full ellipse fits into this rectangle, independent of the attribute draw:kind of the ellipse.
For a draw:caption element this rectangle determines the area into which its text is written.
A draw:regular-polygon element is scaled so that the shape fits into this rectangle."

The elements draw:path, draw:polygon, and draw:polyline have a mandatory svg:viewBox attribute, for a draw:custom-shape it should be given (see issue OFFICE-3824). Therefore a connection to that attribute is possible.

"In case the shape has got a svg:viewBox attribute, the viewBox is mapped to this rectangle."

The suggestions above do not include a suitable description for a 3D-scene. I suggest to remove the reference to 19.571.10 in 19.571.5 <dr3d:scene> and describe it there directly. But I'm not yet familiar enough with 3D-scenes to make a suggestion. Especially the case of a scene as child element in another scene is not clear to me.
 
The only remaining case without description suggestion is a draw:custom-shape without viewbox, but that needs solving OFFICE-3824 first.

Similar problems with using "bounding box" appear in 19.573.5 svg:x and 19.577.5 svg:y, especially if a svg:viewBox attribute exists.

      was (Author: regina.henschel):
    I think, connecting svg:width to "bounding box" is wrong:
- For a draw:caption element I expect, that svg:width and svg:height give the size of the text area, but a draw:caption element has a line to its caption-point in addition. What is the "bounding box" then?
- A draw:custom-shape can have points, which are outside the viewbox and parts of the Bezier-curve for example, can be outside the viewbox too.
- If I use a draw:ellipse element of kind "section" I expect, that the radii and the center of the ellipse do not change, when I vary start- or end-angle.

I suggest: "The attribute svg:width determines together with the attribute svg:height a rectangle, which is a reference for drawing the shape."

And then specify for the different kind of shapes, how this reference is used.

"For a draw:control, draw:frame, draw:rect or draw:page-thumbnail element this rectangle determines the size of the element directly.
A draw:circle element is scaled with keeping aspect ratio, so that the full circle fits into this rectangle, independent of the attribute draw:kind of the circle. The element is placed so that the full circle is centered in this rectangle.
A draw:ellipse element is scaled so that the full ellipse fits into this rectangle, independent of the attribute draw:kind of the ellipse.
For a draw:caption element this rectangle determines the area into which its text is written.
A draw:regular-polygon element is scaled so that the shape fits into this rectangle."

The elements draw:path, draw:polygon, and draw:polyline have a mandatory svg:viewBox attribute, for a draw:custom-shape it should be given (see issue OFFICE-3824). Therefore a connection to that attribute is possible.

"In case the shape has got a svg:viewBox attribute, the viewBox is mapped to this rectangle."

The suggestions above do not include a suitable description for a 3D-scene. I suggest to remove the reference to 19.571.10 in 19.571.5 <dr3d:scene> and describe it there directly. But I'm not yet familiar enough with 3D-scenes to make a suggestion. Especially the case of a scene as child element in another scene is not clear to me.
 
The only remaining case without description suggestion is a draw:custom-shape without viewbox, but that needs solving OFFICE-3824 first.
  
> The addition for draw:circle in 19.571.10 not clear
> ---------------------------------------------------
>
>                 Key: OFFICE-3758
>                 URL: http://tools.oasis-open.org/issues/browse/OFFICE-3758
>             Project: OASIS Open Document Format for Office Applications (OpenDocument) TC
>          Issue Type: Improvement
>          Components: Graphics
>    Affects Versions: ODF 1.2
>            Reporter: Thorsten Zachmann
>
> 19.571.10 states the following:
> 19.571.10 <draw:caption>, <draw:custom-shape>, <draw:circle>,
> <draw:control>, <draw:ellipse>, <draw:frame>, <draw:rect>,
> <draw:page-thumbnail>, <draw:path>, <draw:polygon>,
> <draw:polyline>, <draw:regular-polygon>
> See §5.1.2 of [SVG]. For drawing shapes that have a non rectangular shape, the length refers to
> the drawing shape's bounding box.
> If the svg:width and svg:height attributes specify different values for a <draw:circle>
> element, the radius of the circle is derived from the smaller of the two values, and the circle is
> centered within the bounding box.
> When working on a bug report in Calligra I found out that if there is a draw:circle with a type section LO/AOO uses svg:width, svg:height, svg:x and svg:y as there would be a full circle. This is done in LO/AOO also for a draw:ellipse. However in svg:x and svg:y there is no such notice. It even states "See §5.1.2 of [SVG]. For drawing shapes that have a non rectangular shape, the coordinate
> refers to the drawing shape's bounding box.". In my understanding the bounding box is the rect that encloses the visible part on the screen. So if only a quarter of a circle is shown only the rect around the quarter is the bounding box.
> I would like to clarify what is the intended meaning of the values so that the bug can be fixed correctly.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://tools.oasis-open.org/issues/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira




[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]