[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]
Subject: [OASIS Issue Tracker] (OFFICE-4079) ODF 1.3 CS02 Specification Editorial Fixes
[ https://issues.oasis-open.org/browse/OFFICE-4079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=77490#comment-77490 ]
Svante Schubert edited comment on OFFICE-4079 at 7/17/20 8:21 AM:
------------------------------------------------------------------
Francis, I agree that there should be in general no automatic styling in the XML, this should be fixed by a (semi)automated script - which will become our later pre-commit regression test.
As you mentioned there are exceptions as the automatic styles of table, list and graphic, but the automated script could check their format properties as well. I suggest basing this on ODFDOM instead of XSLT, as Java is easier to program & debug compared to XSLT.
Yesterday, I have fixed the problem scenario you mention within the XSLT not only by adding another [string-join functionality|https://github.com/oasis-tcs/odf-tc/blob/master/src/test/resources/odf1.3/tools/getAttributeDefaults.xsl#L170]Âbut whenever an element styled span is found, the XSLT now [checks if the ending-suffix ">" (or written as & gt; ) exists within the content,|https://github.com/oasis-tcs/odf-tc/blob/master/src/test/resources/odf1.3/tools/getAttributeDefaults.xsl#L167]Âotherwise, the content of the following span element is used as well (which content will be joined to a single string). This handling fixes a lot of the ugliness in the default values ([see the DIFF by pressing on LOAD DIFF of content.odf13-default-values.xml|https://github.com/oasis-tcs/odf-tc/commit/0e0ea9c51eed2c69bf3fb552d1a4860c049ab125#diff-aa382d16c46c761c0af551bd93311e2b]).
was (Author: svante.schubert):
Francis, I agree that there should be in general no automatic styling in the XML, this should be fixed by an automated script - which will become our later pre-commit regression test.
As you mentioned there are exceptions as the automatic styles of table, list and graphic, but the automated script could check their format properties as well. I suggest basing this on ODFDOM instead of XSLT, as Java is easier to program & debug compared to XSLT.
Yesterday, I have fixed the problem scenario you mention within the XSLT not only by adding another [string-join functionality|https://github.com/oasis-tcs/odf-tc/blob/master/src/test/resources/odf1.3/tools/getAttributeDefaults.xsl#L170]Âbut whenever an element styled span is found, the XSLT now [checks if the ending-suffix ">" (or written as >) exists within the content,|https://github.com/oasis-tcs/odf-tc/blob/master/src/test/resources/odf1.3/tools/getAttributeDefaults.xsl#L167]Âotherwise, the content of the following span element is used as well (which content will be joined to a single string). This handling fixes a lot of the ugliness in the default values ([see the DIFF by pressing on the file name of content.odf13-default-values.xml|https://github.com/oasis-tcs/odf-tc/commit/0e0ea9c51eed2c69bf3fb552d1a4860c049ab125#diff-aa382d16c46c761c0af551bd93311e2b]).
> ODF 1.3 CS02 Specification Editorial Fixes
> -------------------------------------------
>
> Key: OFFICE-4079
> URL: https://issues.oasis-open.org/browse/OFFICE-4079
> Project: OASIS Open Document Format for Office Applications (OpenDocument) TC
> Issue Type: Task
> Components: Part (Formula), Part (Introduction), Part (Packages), Part (Schema)
> Affects Versions: ODF 1.3 CS01
> Environment: Deliverables atÂ[http://docs.oasis-open.org/office/OpenDocument/v1.3/]
> Reporter: Svante Schubert
> Assignee: Francis Cave
> Priority: Major
> Labels: editorial
> Fix For: ODF 1.3 CS02
>
>
> # Spacing between Paragraphs (ODT)
> # Line Height higher than Font HeightÂ(ODT)
> # Top Border missing in Paragraph Boxes (HTML)
> # Default Attribute ValuesÂ(ODT)
> *Missing:*
> (x)Â<attribute name="draw:type" defaultValue="standard" element="draw:connector"/>
> (x)Â<attribute name="draw:type" defaultValue="non-primitive" element="draw:enhanced-geometry"/>
> (x)Â<attribute name="number:decimal-places" defaultValue="0" element="number:seconds"/>
> (x)Â<attribute name="smil:accelerate" defaultValue="0"/>
> (x)Â<attribute name="style:vertical-align" defaultValue="top" element="style:column-sep"/>
> *Erroneous:*
> (x)Â<attribute name="xlink:href" defaultValue=""/>
> (x)Â<attribute name="" defaultValue="false"/>
> (x)Â<attribute name="" defaultValue="0"/>
> (x)Â<attribute name="" defaultValue="2"/>
> (x)Â<attribute name="" defaultValue=""/>
> (x)Â<attribute name="" defaultValue="2"/>
> (x)Â<attribute name="" defaultValue="false"/>
> (x)Â<attribute name="" defaultValue="foreground"/>
--
This message was sent by Atlassian Jira
(v8.3.3#803004)
[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]