Re: [pkcs11] PKCS#11 missing or incorrect definitions

[Oscar So <oscar.so@oracle.com>]

Hi Chris,

The issue is with:
CK_ULONG_PTR ulPasswordLen;
in CK_PKCS5_PBKD2_PARAMS.

It should not be a pointer to ULONG. It should just be:
CK_ULONG ulPasswordLen;

The straw poll suggested that we should NOT change
"CK_ULONG_PTR ulPasswordLen" inside CK_PKCS5_PBKD2_PARAMS,
we should define a NEW struct for CK_PKCS5_PBKD2_PARAMS.
And, we should deprecate CK_PKCS5_PBKD2_PARAMS.

Refer to:
https://www.oasis-open.org/apps/org/workgroup/pkcs11/download.php/49138/ballot_2399.html?referring_url=%2Fkws
"Create new mechanism/structure and deprecating existing. 28 84 28/33"

BUT,
I could not find where this NEW struct is ?

Thanks,
Oscar






On 06/23/14 10:35 AM, Chris Zimman wrote:
> Hi Oscar
>
> Here's what we have right now in the CDS:
>
> *	CK_ PKCS5_PBKD2_PARAMS; CK_PKCS5_PBKD2_PARAMS_PTR
> 	CK_PKCS5_PBKD2_PARAMS is a structure that provides the parameters to the CKM_PKCS5_PBKD2 mechanism.
> 	The structure is defined as follows:
>
> typedef struct CK_PKCS5_PBKD2_PARAMS {
> 	CK_PKCS5_PBKDF2_SALT_SOURCE_TYPE saltSource;
> 	CK_VOID_PTR pSaltSourceData;
> 	CK_ULONG ulSaltSourceDataLen;
> 	CK_ULONG iterations;
> 	CK_PKCS5_PBKD2_PSEUDO_RANDOM_FUNCTION_TYPE prf;
> 	CK_VOID_PTR pPrfData;
> 	CK_ULONG ulPrfDataLen;	
> 	CK_UTF8CHAR_PTR pPassword;
> 	CK_ULONG_PTR ulPasswordLen;
> } CK_PKCS5_PBKD2_PARAMS;
>
> The fields of the structure have the following meanings:
> 	saltSource	source of the salt value
> 	pSaltSourceData	data used as the input for the salt source
> 	ulSaltSourceDataLen 	length of the salt source input
> 	iterations	number of iterations to perform when generating each block of random data
> 	prf 	pseudo-random function used to generate the key
> 	pPrfData	data used as the input for PRF in addition to the salt value
> 	ulPrfDataLen	length of the input data for the PRF
> 	pPassword	points to the password to be used in the PBE key generation
> 	ulPasswordLen	length in bytes of the password information
> CK_PKCS5_PBKD2_PARAMS_PTR is a pointer to a CK_PKCS5_PBKD2_PARAMS.
>
> What is being proposed for change here?  I looked at the straw poll, but it's not entirely clear to me.
>
> Thanks
>
> --Chris
>
> -----Original Message-----
> From: pkcs11@lists.oasis-open.org [mailto:pkcs11@lists.oasis-open.org] On Behalf Of Oscar So
> Sent: Monday, June 23, 2014 12:16 PM
> To: pkcs11@lists.oasis-open.org
> Subject: Re: [pkcs11] PKCS#11 missing or incorrect definitions
>
> Thanks Stef and Chris.
>
>
> Chris,
>
> Can you also take a look at this issue ?
>
> https://www.oasis-open.org/apps/org/workgroup/pkcs11/download.php/49138/ballot_2399.html
>
>   From the above ballot, we agree to define a new structure for CK_PKCS5_PBKD2_PARAMS.
>
> I am looking for this new structure definition in oasis-open.org, but I could not find it. I don't even know the new name.
>
> Do you know how does this newly defined structure looks like for v2.40 ?
>
>
> Thanks!
>
> Best,
> Oscar
>
>
>
>
>
> On 06/23/14 08:57 AM, Chris Zimman wrote:
> > Hi Stef
> >
> > Thanks for doing this.  I've gone through each of these items and corrected where possible.  I'm going to review once more later today and then post an updated CSD.
> >
> > Thanks
> >
> > --Chris
> >
> > -----Original Message-----
> > From: pkcs11@lists.oasis-open.org [mailto:pkcs11@lists.oasis-open.org]
> > On Behalf Of Stef Walter
> > Sent: Friday, June 20, 2014 4:00 PM
> > To: pkcs11@lists.oasis-open.org
> > Subject: [pkcs11] PKCS#11 missing or incorrect definitions
> >
> > So rather than just complain, I've put together a list of all the
> > incorrect, mispelled, or missing definitions/constants in the PKCS#11
> > v2.40 spec:
> >
> > https://wiki.oasis-open.org/pkcs11/Definitions
> >
> > About 40 missing and 40 incorrect/misspelled. Hope this is helpful.
> >
> > Cheers,
> >
> > Stef
> >
> > ---------------------------------------------------------------------
> > To unsubscribe from this mail list, you must leave the OASIS TC that generates this mail.  Follow this link to all your TCs in OASIS at:
> > https://www.oasis-open.org/apps/org/workgroup/portal/my_workgroups.php
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe from this mail list, you must leave the OASIS TC that
> > generates this mail.  Follow this link to all your TCs in OASIS at:
> > https://www.oasis-open.org/apps/org/workgroup/portal/my_workgroups.php
>
>
> ---------------------------------------------------------------------
> To unsubscribe from this mail list, you must leave the OASIS TC that generates this mail.  Follow this link to all your TCs in OASIS at:
> https://www.oasis-open.org/apps/org/workgroup/portal/my_workgroups.php