RE: [pkcs11] Groups - EdDSA Using Additional Key Types uploaded uploaded

[Johnson Darren <darren.johnson@gemalto.com>]

Hi Jakub,
Thanks for the review.  I'll make those corrections.

Darren

-----Original Message-----
From: Jakub Jelen [mailto:jjelen@redhat.com]
Sent: Thursday, November 16, 2017 3:56 AM
To: Johnson Darren <darren.johnson@gemalto.com>; pkcs11@lists.oasis-open.org
Subject: Re: [pkcs11] Groups - EdDSA Using Additional Key Types uploaded uploaded

On Wed, 2017-11-15 at 12:56 -0800, Darren Johnson wrote:
> Submitter's message
> This is an updated version of proposal #3, "EdDSA Using Additional Key
> Types" uploaded.
>
>          -- Mr. Darren Johnson
>          -----------------
> Document Name: EdDSA Using Additional Key Types uploaded Description
> This is an updated version of proposal #3, "EdDSA Using Additional Key
> Types" uploaded.
> View Details: https://www.oasis-open.org/apps/org/workgroup/pkcs11/do
> cument.php?document_id=62058
> Download Latest Revision: https://www.oasis-open.org/apps/org/workgro
> up/pkcs11/download.php/62058/latest/eddsa_notes_Additional_EC_Key_Typ
> es_draft2.docx
> Public Download Link: https://www.oasis-open.org/committees/document.
> php?document_id=62058&wg_abbrev=pkcs11
> -----------------
> Submitter: Mr. Darren Johnson
>
> Group: OASIS PKCS 11 TC
> Folder: Documents
> Date submitted: 2017-11-15 12:56:20
>
>
> -----------------

I re-read this version of the document and noticed few minor issues:

I noticed a typo in 1.1.15 EC mechanism parameters, there is a missing D in CK_EDSA_PARAMS structure name.

If I understand the structure correctly, the 1.1.2 Definitions should also list the new CKM's explained in the table above, should not it?

Thanks,
--
Jakub Jelen
Software Engineer
Security Technologies
Red Hat, Inc.
________________________________
 This message and any attachments are intended solely for the addressees and may contain confidential information. Any unauthorized use or disclosure, either whole or partial, is prohibited.
E-mails are susceptible to alteration. Our company shall not be liable for the message if altered, changed or falsified. If you are not the intended recipient of this message, please delete it and notify the sender.
Although all reasonable efforts have been made to keep this transmission free from viruses, the sender will not be liable for damages caused by a transmitted virus.