RE: [pkcs11] Initial review of Draft 3 of PKCS #11 mechanisms 3.0

All,

I have reviewed WD03, focusing on “my” proposals:

· I also noticed the formatting issues on pages 14, 15 and 16 pointed out by Bob. These are due to leading spaces and differing indentation. I have fixed these issues.

· Numbering of tables is not correct anymore, caused by insertion of new chapters/tables. E.g. there are tables 65 / 66 / 67 in section 2.14, and then section 2.15 starts with table 65 again. I have NOT updated table numbers throughout this working draft.

· Review of AES Key Wrap => ok. I noticed a few superfluous spaces (which I missed to flag/remove in my proposal) and removed them. PKCS#11 3.0 work items table is updated.

· Review of ECDH Key Derivation => ok, but added CKD_SHA244_KDF_SP800, CKD_SHA256_KDF_SP800, CKD_SHA384_KDF_SP800, and CKD_SHA512_KDF_SP800 to the table 34 (see also Bob’s comment below). PKCS#11 3.0 work items table is updated.

· Reviewed v2.40 Errata - Item 16 - Add definitions for ECDSA SHA2 and SHA3 mechanisms: As Bob noted, I could not find this back in WD03. I have taken the freedom to include CKM_ECDSA_SHA_xxx (SHA2) and CKM_ECDSA_SHA3_xxx mechanisms in my review version. And instead of adding 8 new sections (one for each of the SHA2 and SHA3 mechanisms), I updated section 2.3.7 using the same approach as in my ECDH key derivation proposal, and changed the title of section 2.3.7 to “ECDSA with hashing”. PKCS#11 3.0 work items table is not updated yet for this item, as I ask somebody else (Bob?) to review my update.

Please see the reviewed and updated version attached. All changes to Chris’ WD03 are marked with track changes.

Best regards,

Dieter

From: pkcs11@lists.oasis-open.org [mailto:pkcs11@lists.oasis-open.org] On Behalf Of Robert Relyea
Sent: Donnerstag, 4. Januar 2018 20:54
To: pkcs11@lists.oasis-open.org
Subject: [pkcs11] Initial review of Draft 3 of PKCS #11 mechanisms 3.0

I'm about halfway through, but did come of with some things that need to be addressed and possible some questions. that need to be answered. Some answers I think Chris had about placement are given below.

Page 1
- line 8: Redhat should be Red Hat (we get it drummed into our heads all the time here).
- lines 22-41: shouldn't these be updated to the 3.0 versions, of the spec or do we wait until the 3.0 versions are ready (chicken and egg issue?).
Page 2
- line 51: Copyright is wrong. I don't know if it should be 2018, or a list (2015,2018 2015,2016,2017,2018)) but I'm pretty sure it should not be just 2015.
Pages 3-11
- table of contents doesn't look like it totally matches the spec. For instance, the SHA-3 mechanisms associated with RSA and DSA don't show up in the table of contents even though I found them in the spec.
Page 14
- I'm seeing some formatting problems at lines 528-539. May be just my viewer (openoffice) however.
Page 15
- Same type of formatting problem at lines 582-584.
Page 16
- Same type of formatting problems at lines 606-608,612-620, and 624
Page 18
- I don't see any instances of footnote 3 (line 673) in the table.
Page 19
- The paragraphs starting at line 718 and continuing through line 729 (on page 20) are out of place. They should be moved to just before paragraph 2.1.15 at line 117 on page 33. I would be OK with them moving after paragraph 2.1.16 as well, but they should be in this part of the spec, not in the middle of the definitions.
Page 56
- The new CKM_ECDSA_SHA_xxx (SHA2) and CKM_ECDSA_SHA3_xxx mechanisms are missing. I'm pretty sure we've approved them, I wonder if they didn't make the work flow table.
Page 57
- CKD_SHA244_KDF_SP800, CKD_SHA256_KDF_SP800, CKD_SHA384_KDF_SP800, and CKD_SHA512_KDF_SP800 are referenced in the text, but missing from the table at line 1862. This is probably an issue with the original source text sent to Chris.
Pages 92-98
- lines 3042-3241 are misplaced. They are intended to replace sections 2.12.4 and 2.12.5 lines 3346-3406 on pages 102 and 103.
- In addition there appears copy/paste issues lines 3064 through 3102 should be deleted. I think we'll need another close review once the changes are made on this one.
- Line 3109 CKG_NO_GENERATe should be CKG_NO_GENERATE
Pages 120,122,124,127,129,131, and 133
- lines 3811,3862,3913,3965,4020,4074 and 4123 - The labels for the new HMAC key gen mechanisms appear to me mistagged (formatting issue).
Pages 134,137,140, and 143
- The text "This section defines key type "CKK_SHA3_xxxx_HMAC" for type CK_KEY_TYPE as used in the CKA_KEY_TYPE attribute of key objects" is missing from the top of the Definitions section. The same wording appears in the SHA1 and SHA2 sections. This is probably an error in the source document supplied to Chris.
Pages 148-149
- Table at line 4421. We should probably add CKP_PKCS5_PBKDF2_HMAC_SHA3_XXX entries.

pkcs11 message