OASIS Mailing List ArchivesView the OASIS mailing list archive below
or browse/search using MarkMail.


Help: OASIS Mailing Lists Help | MarkMail Help

saf-comment message

[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]

Subject: SAF Primer feedback

Posted on behalf of Doug Davis…


 I looked over the SAF/CIMI doc and have just a few comments:

- change <<CIMI "get">> to <<CIMI "GET">>

- uses old version of CIMI but I'm assuming that will be automatically fixed

- no need for xpath.count() we now have a count property in each collection (sec 3.1.1)

- I think the loop in 3.1.1 (starts with: For each new machine…) is off.  If $new_machine_count is zero it'll still add a new machine.  And, when the count hits zero it still adds one more since it says >= 0  and not > 0 in the while statement.  So, if $new_machine_count starts at 1, this will actually add 2 machines. But I don't know Ruby so I could be wrong.

-Doug Davis
STSM |  Standards Architect  |  IBM Software Group

[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]