[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]
Subject: Re: Error in comprehensive SARIF example
Also on line 641 there's a missing coma: "module": "platform", "threadId": 52 "parameters": [ "null", Should be "module": "platform", "threadId": 52, "parameters": [ "null", And on line 713 there's a missing closing bracket: { "offset": 100, "fullyQualifiedName": "collections.dll!collections::list::add", "kind": "function", "parentIndex": 0 { "offset": 22, "fullyQualifiedName": "collections.dll!collections::list::add+0x16", "parentIndex": 1 } Should be { "offset": 100, "fullyQualifiedName": "collections.dll!collections::list::add", "kind": "function", "parentIndex": 0 }, { "offset": 22, "fullyQualifiedName": "collections.dll!collections::list::add+0x16", "parentIndex": 1 } On Sun, Dec 15, 2019 at 9:45 AM Pascal Berger <pascal.berger@gmail.com> wrote: > > Another on on line 419: > > "baselineState": "existing", > > Based on point 3.27.24 in the specs "existing" is not a valid value here. > > best > pascal > > On Sun, Dec 15, 2019 at 9:43 AM Pascal Berger <pascal.berger@gmail.com> wrote: > > > > Another one on line 231: > > > > "exception": { > > "kind": "ExecutionEngine.RuleFailureException", > > "message": { > > "text": "Unhandled exception during rule evaluation." > > }, > > > > Based on the spec the exception message is just a string. So it should be: > > > > "exception": { > > "kind": "ExecutionEngine.RuleFailureException", > > "message": "Unhandled exception during rule evaluation.", > > > > best > > pascal > > > > On Sun, Dec 15, 2019 at 9:40 AM Pascal Berger <pascal.berger@gmail.com> wrote: > > > > > > Hi, > > > There's an error in the comprehensive SARIF example in K.4 on line 95: > > > > > > "shortDescription": { > > > "text": "The run ended". > > > }, > > > > > > The . for the text needs to be inside the quoted text. > > > > > > Best > > > pascal
[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]