[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]
Subject: RE: [sarif] Change draft for #63 and #64: files dictionary property names
I corrected the section that explains when the “uri base id prefix” is required and pushed a revision to the change draft. The change draft is here (NOT at the link I provided below, which was a copy-paste error):
Unfortunately, to make this precise, I had to essentially rewrite §188.8.131.52, “Property names”. Please do read it carefully.
If you haven’t yet read this draft, you can ignore this mail.
I made a small mistake in this draft. The draft correctly states that the “uri base id prefix” is mandatory if it’s needed to avoid a file dictionary key collision. But the language of the draft effectively prohibits the prefix if there are no collisions. There’s nothing inherently wrong with that, but it’s contrary to what Michael and I agreed on and intended to propose. We intended to allow the prefix, even if it wasn’t necessary, to accommodate SARIF producers that didn’t want to take the trouble to look for collisions before deciding whether to include the prefix.
You can read the draft as it is; just be aware that I’m going to update it to fix that problem.
I pushed a change draft for the following two closely related issues:
Issue #63: Clarify that the keys in the run.files dictionary must be distinct when normalized
Issue #64: run.files keys can collide if specified by relative URLs
Please take a look at those issues, especially the solution described in Issue #64, before reading the change draft, which is here:
I added these items to the Agenda that’s checked into the repo, and I’ll move for their adoption at the next TC meeting.