OASIS Mailing List ArchivesView the OASIS mailing list archive below
or browse/search using MarkMail.

 


Help: OASIS Mailing Lists Help | MarkMail Help

sarif message

[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]


Subject: RE: [sarif] Issue #134: conversion.analysisToolLogFileLocation should be an array


Jim can help answer “does any tool behave that way today”. The question “is it a good idea to allow for the possibility” is more a judgment call.

 

Larry

 

From: Michael Fanning <Michael.Fanning@microsoft.com>
Sent: Tuesday, March 27, 2018 2:15 PM
To: Larry Golding (Comcast) <larrygolding@comcast.net>; sarif@lists.oasis-open.org
Subject: RE: [sarif] Issue #134: conversion.analysisToolLogFileLocation should be an array

 

This is Jim’s to answer, is my guess.

 

Michael

From: sarif@lists.oasis-open.org <sarif@lists.oasis-open.org> On Behalf Of Larry Golding (Comcast)
Sent: Tuesday, March 27, 2018 10:28 AM
To: sarif@lists.oasis-open.org
Subject: RE: [sarif] Issue #134: conversion.analysisToolLogFileLocation should be an array
Importance: High

 

I looked more closely at this, and I want to make sure that this is the right change. As the spec stands, it covers the following scenarios:

 

  1. The analysis tool produces a exactly one log file containing all results. This is the most common scenario. In this case, the converter populates conversion.analysisToolLogFileLocation with the location of that file.
  2. The analysis tool produces one or more separate log files for each result. In this case, for each result, the converter populates result.conversionProvenance[n].analysisToolLogFileLocation with the locations of those result-specific files. Note that result.conversionProvenance is an array of fileLocation objects {*}.

 

The spec does not convered this scenario:

 

  1. The analysis tool produces more than one log file, each of which contains a portion of the information for all results. This is the case were we would want conversion.analysisToolLogFileLocations to be an array.

 

So – Is #3 a realistic scenario? Even if no tool behaves that way today, wouldn’t it be a good idea to allow for the possibility?

 

Thanks,

Larry

 

{*} Fun fact: this is the only place in the spec where an array-valued property does not have a plural name. We discussed “conversionProvenances” and rejected it.

 

From: sarif@lists.oasis-open.org <sarif@lists.oasis-open.org> On Behalf Of Larry Golding (Comcast)
Sent: Tuesday, March 27, 2018 9:19 AM
To: sarif@lists.oasis-open.org
Subject: [sarif] Issue #134: conversion.analysisToolLogFileLocation should be an array
Importance: High

 

I just noticed this. It’s a tiny change and I think we need it for CSD.1:

 

Some analysis tools emit multiple files. A converter might need more than one of them to produce a SARIF log file. So the property conversion.analysisToolLogFileLocation of type fileLocation should be changed to analysisToolLogFileLocations of type fileLocation[].

 

Larry



[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]