[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]
Subject: RE: [sarif] Issue #134: conversion.analysisToolLogFileLocation should be an array
Hearing no objections, I’m closing #134. Jim, if you know of a tool that requires it, please let me know and I’ll reopen it. Larry From: sarif@lists.oasis-open.org <sarif@lists.oasis-open.org> On Behalf Of Larry Golding (Comcast) Michael wrote: Agreed, and I trust Jim’s judgment most here because he has most experience with complex conversion scenarios. This situation has never materialized in any Microsoft driven converter scenarios. Most of SARIF (I hope) is proposed for well-substantiated use cases, in general, ‘allowing for possibilities’ isn’t a typical design principle. So Jim (or anyone), are you aware of any tool that behaves in a way that requires conversion.analysisToolLogFileLocation to be an array? That is, are you aware of any tool that behaves like Scenario #3 below?
If not, I’m going to close #134. Thanks, Larry From: Larry Golding (Comcast) <larrygolding@comcast.net> Jim can help answer “does any tool behave that way today”. The question “is it a good idea to allow for the possibility” is more a judgment call. Larry From: Michael Fanning <Michael.Fanning@microsoft.com> This is Jim’s to answer, is my guess. Michael From: sarif@lists.oasis-open.org <sarif@lists.oasis-open.org> On Behalf Of Larry Golding (Comcast) I looked more closely at this, and I want to make sure that this is the right change. As the spec stands, it covers the following scenarios:
The spec does not convered this scenario:
So – Is #3 a realistic scenario? Even if no tool behaves that way today, wouldn’t it be a good idea to allow for the possibility? Thanks, Larry {*} Fun fact: this is the only place in the spec where an array-valued property does not have a plural name. We discussed “conversionProvenances” and rejected it. From: sarif@lists.oasis-open.org <sarif@lists.oasis-open.org> On Behalf Of Larry Golding (Comcast) I just noticed this. It’s a tiny change and I think we need it for CSD.1: Some analysis tools emit multiple files. A converter might need more than one of them to produce a SARIF log file. So the property Larry |
[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]