Subject: RE: [sarif] "generatedFile" => "uncontrolledFile"
Also, Jim pointed out that issues might be found in standard library files. So, there are really three classes of files:
One possibility is:
*sigh* Actually there is a possible use. It’s often not possible to fix bugs in generated files, because you don’t have control of the generator. So a team might well decide to ignore all issues in generated files, so that role might be useful.
Of course in that case the team should just exclude the generated files from analysis. After all, if they know enough to mark the files as “generated” in the files dictionary, then they know exactly which files were generated.
So I’m still on the fence (but still leaning towards a simple rename).
Any thoughts from anyone else?
The purpose of these roles is to help a SARIF consumer who can’t access a VCS to decide what files have changed (and so might need to be reanalyzed). Given that, I don’t see a useful distinction between a generated file and any other file that’s not under source control. In either case, the consumer either has to assume that the file has changed, or it has to keep track of a last-modified time, or a hash, of the file.
So I think generatedFile is not necessary as a separate property, and I propose we rename it to uncontrolledFile.
It may be useful to have both of these. generatedFile implies uncontrolledFile, but there are other referenced files that are uncontrolled, but not generated, such as files that are part of the standard library of the language.
If generatedFile is not useful, then uncontrolledFile is probably a better name.
On 05/17/2018 01:29 PM, Larry Golding (Comcast) wrote:
> For purposes of file.roles, generated files are interesting because
> they’re not under source control. There might be other files that are
> not under source control. Shall we rename "generatedFile" to
> "uncontrolledFile"? (Other name suggestions welcome.)
To unsubscribe from this mail list, you must leave the OASIS TC that generates this mail. Follow this link to all your TCs in OASIS at: