[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]
Subject: RE: Two unrelated issues in one change draft
I uploaded a sample SARIF file to illustrate the changes: https://github.com/oasis-tcs/sarif-spec/blob/master/Documents/ScratchSamples/179-311.sarif Please take a look at your earliest convenience. I’m going to start writing now because Michael and I have looked at this quite carefully, including implementing it in the SDK, so we’re pretty confident in the structure. Thanks, Larry From: Larry Golding (Myriad Consulting Inc) <v-lgold@microsoft.com>
I missed a few properties below. We also need:
In the notification object:
·
Rename the property ruleId to associatedRuleId.
// The two renames are to clarify that this id and index do not refer to the notification itself, but rather to the rule (if any) to which the notification is relevant. Example:
“The rule CS2001 threw an exception and has been disabled.”
·
Rename the property ruleIndex to associatedRuleIndex.
·
Add a property associatedRuleExtensionIndex of
type integer, default: -1.
optional.
·
Add a property notificationIndex of
type integer, default: -1.
optional.
·
Add a property notificationExtensionIndex of
type integer, default: -1.
optional. Thanks, Larry From: sarif@lists.oasis-open.org <sarif@lists.oasis-open.org>
On Behalf Of Larry Golding (Myriad Consulting Inc) Here is the net result of these two changes, as summarized in the
schema changes document. (The comments do not appear in the schema changes document.) I am crafting a sample SARIF file to demonstrate all this, but I wanted to get this out to you ASAP. Please take a look, because this is going to be a lot of writing! Issue
#179: "Consider whether SARIF covers plug-ins/rules versioning sufficiently" and Issue
#311: "Provide full metadata objects for notifications"
NOTE: We describe the combined result of both of these changes, because both of them affect the location of rule metadata.
Rename the existing
Rename the existing
Define a
·
All previously existing properties of the
·
·
·
·
In the
·
Remove the
·
Move all remaining properties except for
·
Add a property
·
Add a property
In the
·
Rename the
In the
·
Rename the
·
Rename the
Define a
·
·
·
·
In the
·
Add a
In the
·
Remove the
Remove the
In the
·
Add a property
In the
·
Rename the Thanks, Larry From: sarif@lists.oasis-open.org <sarif@lists.oasis-open.org>
On Behalf Of Larry Golding (Myriad Consulting Inc) For practical reasons, I’m going to produce a change draft that contains two seemingly unrelated changes:
The reason is that both of these changes have an effect on where the rule metadata ends up:
… and the end result is that rule metadata ends up living in
toolComponent. Since we agreed in principle to both of these changes during the F2F, I’m not worried about wasting effort by combining the drafts, and I think it will help you to see the overall result in a single draft. I should be able to get a draft
out by end of day tomorrow. Thanks, Larry |
[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]