RE: #383: Yekaterina's feedback

Thanks! Fixed typo. Fixed most font size issues; a few were intentional (for example, to fit something on a single line).

From: Yekaterina O'Neil <katrina@microfocus.com>
Sent: Monday, April 22, 2019 10:19 AM
To: Larry Golding (Myriad Consulting Inc) <v-lgold@microsoft.com>; OASIS SARIF TC Discussion List <sarif@lists.oasis-open.org>
Subject: RE: #383: Yekaterina's feedback

A couple of more pieces of minor (except for highlighted) feedback:

p.24, section 2.4, first example uses font size, 9, second – font size 10

p.28, section 3.4.4, first example uses font size 8, second – font size 9

p. 38, section 3.10.4, “§3.1of the standard” – missing space before “of”

p. 76, section 3.20.2, first and third example use font size 9, second – font size 10

p.94, section 3.25.7, “downloadUri” should be substituted with “informationUri”

p.105, section 3.26.16, example uses fonts 9 and 10 together

p.157, section 3.48.2, example uses font size 8

p.186, section F7, examples use font size 8

p.188-190, section H, examples use font size 8

p.193-205, section J, examples use font size 8

From: Larry Golding (Myriad Consulting Inc) [mailto:v-lgold@microsoft.com]
Sent: Thursday, April 18, 2019 3:22 PM
To: OASIS SARIF TC Discussion List <sarif@lists.oasis-open.org>
Cc: Yekaterina O'Neil <katrina@microfocus.com>
Subject: RE: #383: Yekaterina's feedback

Issue #390 is now “Make certain invocation and versionControlDetails properties redactable”.

From: sarif@lists.oasis-open.org <sarif@lists.oasis-open.org> On Behalf Of Larry Golding (Myriad Consulting Inc)
Sent: Thursday, April 18, 2019 3:21 PM
To: OASIS SARIF TC Discussion List <sarif@lists.oasis-open.org>
Cc: 'O'Neil, Yekaterina Tsipenyuk' <katrina@microfocus.com>
Subject: [sarif] #383: Yekaterina's feedback

Yekaterina:

Thanks for such a thorough reading. I addressed the bulk of your issues (the editorial changes) in a single change draft:

https://github.com/oasis-tcs/sarif-spec/blob/master/Documents/ChangeDrafts/Accepted/sarif-v2.0-issue-383-yto-editorial.docx

I merged it into the provisional draft

https://github.com/oasis-tcs/sarif-spec/blob/master/Documents/ProvisionalDrafts/sarif-v2.0-csd02-provisional.docx

and closed the issue. My point-by-point responses are in this issue comment.

I opened issues to track your substantive feedback:

Issue #381: Associate descriptor metadata with thread flow locations
Issue #390: Make certain invocation properties redactable

Thanks,

Larry

sarif message