RE: run.language discrepancy between spec and schema

["Larry Golding (Myriad Consulting Inc)" <v-lgold@microsoft.com>]

Thanks Jim,

I will make this change. This is Issue #402.

Larry

-----Original Message-----
From: James Kupsch <kupsch@cs.wisc.edu> 
Sent: Monday, April 29, 2019 6:38 AM
To: Michael Fanning <Michael.Fanning@microsoft.com>; OASIS SARIF TC Discussion List <sarif@lists.oasis-open.org>; Larry Golding (Myriad Consulting Inc) <v-lgold@microsoft.com>
Subject: Re: run.language discrepancy between spec and schema

I do not recall any discussion about this.  I agree that using ISO 639-1
  and ISO 3166-1 for the value is sufficient.

Jim


On 4/27/19 2:18 PM, Michael Fanning wrote:
> Larry and I are (rather desperately) trying to button down the eballot 
> doc. We've found a difference between the spec and the schema that 
> neither of us can recall sufficient detail on to resolve. Anyone else 
> remember anything? Absent inputs, we're favoring the use of ISO 639-1 
> and ISO 3166-1 for the reason that this data appears sufficient for 
> string mgmt. and it is a non-breaking change to expand to RFC5646 (but 
> a breaking change to move in the other direction).
> 
> Michael
> 
> The spec mandates RFC5646 to populate |run.language|. The schema 
> specifies that this property is constrained to a proper subset of 
> RFC5646, consisting of an ISO 639-1 country code and an optional ISO
> 3166-1 region code.
> 
> Larry and I can't locate any history that helps us figure out how this 
> discrepancy materialized. The RFC5646 requirement is long-standing (in 
> fact, dates back to SARIF v1). The most likely scenarios are that we 
> either changed the requirement and failed to update the spec. Or that 
> we updated the schema speculatively in the SDK and someone made a 
> successful case against the change in TC discussion.
> 
> Does anyone recall the history on this? *@kupsch* 
> <https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fkupsch&amp;data=01%7C01%7Cv-lgold%40microsoft.com%7C0da14c4b58b34ff6235c08d6cca7df24%7C72f988bf86f141af91ab2d7cd011db47%7C1&amp;sdata=ifJDMiBKgYtsNbrkQeyS3gbJADJpjve6pOQZs%2FvdTzY%3D&amp;reserved=0>?
> 
> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgith
> ub.com%2Foasis-tcs%2Fsarif-spec%2Fissues%2F402&amp;data=01%7C01%7Cv-lg
> old%40microsoft.com%7C0da14c4b58b34ff6235c08d6cca7df24%7C72f988bf86f14
> 1af91ab2d7cd011db47%7C1&amp;sdata=q%2BfEhq7FqPXm862aJEd5IS8JWldKk3ep4B
> 1dNeSjGB0%3D&amp;reserved=0
>