Re: [sca-assembly] Some review comments on sca-assembly-1.1-spec-cd02-Rev3.pdf

[C Vamsi <vamsic007@in.ibm.com>]

Some more comments:

Line 870: 4.3.1 instead of 5.3.1?

Section 4.4 name should be Component Property?

Line 1064: @name attribute

Line 1064-1066: Should the wording be made consistent with that of service
and reference elements?

Line 1078: change to "Overrides the many specified for this property in the
component type of the implementation."

Lines 1152-1154: Multiple property elements with same property name is a
violation of "[ASM50030]"

Line 1157: stockQuoteService with a small s

Line 1166: stockQuoteService with a small s


++Vamsi
Apache Tuscany Committer  http://tuscany.apache.org
Apache Geronimo Committer and Member of PMC  http://geronimo.apache.org


                                                                       
             C                                                         
             Vamsi/India/IBM@I                                         
             BMIN                                                       To
                                       sca-assembly@lists.oasis-open.org
             05/02/2009 01:26                                           cc
                                                                       
                                                                   Subject
                                       [sca-assembly] Some review comments
                                       on                              
                                       sca-assembly-1.1-spec-cd02-Rev3.pdf
                                                                       
                                                                       
                                                                       
                                                                       
                                                                       
                                                                       



I have reviewed the document partially and here are some comments on
sca-assembly-1.1-spec-cd02-Rev3.pdf:

Line 212: component with small c

Line 225: us xs:QName for consistency

Line 245: What does implementation 0..1 mean?

Line 377: "zero or more" in bold font.

Line 431-432: Change to "The implementation can use the supplied value in
any way that it chooses."

Section 3.1.4 does not talk about 0..1 for implementation

Line 464: implementation instead of implementationervice

Line 508: tags or annotations?

Should example in 3.3 use @Service annotation as well?

Line 578: Should the componentType have implementation.java tag as it is
computed from the java class?

Line 596: Is it possible to get the default value for the field by
introspection?

Line 600: "Component Implementation" spec instead of "Client and
Implementation" spec?

Line 607-608: Not true for Java EE

Line 609: in xxx.composite is xxx needed?

Section 4.1 name should be Component Implementation?

Section 4.2 name should be Component Service?

Section 4.3 name shoulde Component Reference?

Lines 791-792: replace 2 occurrences of "service" with "reference".

I will post more comments as I review further.  I would like to know if I
need to raise NEW ISSUE for some of these.

++Vamsi
Apache Tuscany Committer  http://tuscany.apache.org
Apache Geronimo Committer and Member of PMC  http://geronimo.apache.org


---------------------------------------------------------------------
To unsubscribe from this mail list, you must leave the OASIS TC that
generates this mail.  Follow this link to all your TCs in OASIS at:
https://www.oasis-open.org/apps/org/workgroup/portal/my_workgroups.php