Review comments on sca-assembly-1.1-spec-cd02-Rev4.doc (sent out on 6th Feb)

[C Vamsi <vamsic007@in.ibm.com>]

There are now two sca-assembly-1.1-spec-cd02-Rev4.doc documents, one sent
out today and the other on 6th Feb.  The following comments are based on
sca-assembly-1.1-spec-cd02-Rev4.doc sent out on 6th Feb.

Comments for chapters 5 through 12 based on
"sca-assembly-1.1-spec-cd02-Rev4.doc" -- Committee Draft 02 - Revision 4 -
06th February 2009
Doc link:
http://www.oasis-open.org/committees/download.php/31083/sca-assembly-1.1-spec-cd02-Rev4.doc

Line 1199: use xs:QName for consistency

Line 1217: Extra "must"

Line 1227: "are" instead of "is"

Line 1312: Extra "must"

Line 1365: stockQuoteService with a small s

Line 1400: "than" instead of "then"

Line 1417: Is "strict" needed?

Line 1452: "e.g.," instead of "eg" (through out the doc ?)

Should the paragraph at line 1457 say what happens when some values are set
to true and some are set to false?

Line 1485: 4.3.1 instead of 5.3.1

Line 1526: stockQuoteService with a small s

Line 1539: stockQuoteService with a small s

Line 1571: "@name attribute" instead of "name attribute"

Line 1578: Usage of article with attribute names. "an @type attribute" or
"a @type attribute"?

Line 1739-40: "target attribute" or "@target attribute"?

Line 1754: what does "reference element of a service" mean?

Line 1805: "return type" instead of "return value"

Line 2062: The following *is* an ...

Line 2159: "the SCA Domain" instead of "the Domain".

Line 2319-2321 say: "The constrainingType specifies the services,
references and properties that MUST be implemented by the

implementation of the component to which the constrainingType is attached."

"implemented" does not seem to be appropriate here. Suggest to use
"provided" instead.

Line 2325: "does" instead of "do".

Line 2388: stockQuoteService with a small s

Line 2476: says, "This can be done using the @AllowsPassByReference
annotation." - Sounds as if this is the only way of doing

it!

Line 2667: database as one word.

Line 2718: what is binding.composite??

Line 2729: 4.3.1 instead of 5.3.1

Line 2732: "@name attribute" instead of "name attribute"

Line 2733: "@name attribute" instead of "name attribute"

Line 2735: "@name attribute" instead of "name attribute"

Line 2737: extra "must"

Line 2753: "service is available through any of the ..." instead of
"service is available by any of the ..."

In the doc, some places it is "SCA domain" and other places it is "SCA
Domain". Should it be consistent across the doc?

Line 2759-2760: The first sentence needs punctuation.

"If a reference has any bindings, they MUST be resolved. This means that
each binding MUST include a value for the @URI

attribute or MUST otherwise specify an endpoint."

instead of

"If a reference has any bindings they MUST be resolved which means that
each binding MUST include a value for the @URI

attribute or MUST otherwise specify an endpoint."

Line 2789 to 2792: should there be only two bullets instead of four?

Line 2809 to 2910: should there be only one bullet instead of two?

Line 2830-2831: "@uri attribute" instead of "uri attribute"

Line 2874: "honored" instead of "respected"?

Line 2879: "a URI" or "an URI"?

Line 2962-2964:

"New interface types, implementation types and binding types that are
defined using this extensibility model, which are not

part of these SCA specifications MUST be defined in namespaces other than
the SCA namespace."

instead of
"New interface types, implementation types and binding types that are
defined using this extensibility model, which are not

part of these SCA specifications are defined in namespaces other than the
SCA namespace."

Before line 3358, should there be a paragraph introducing the chapter?

Line 3452: Remove "either"

Line 3492: "i.e.," instead of "ie" across the document.

Line 3528: Typo: artifact instead of srtifact

Line 3562: "the export" instead of "theexport"

Line 3572: "can be used" is repeated

Line 3590: "can be used" is repeated

Line 3625: "An up to date..." instead of "A up to date..."

Line 3740: "an installed contribution" instead of "a installed
contribution"

Line 3809: Remove the period after "component".

Line 3811: "alternatively" instead of "alternative". Typo in component -
"compoennt"


++Vamsi
Apache Tuscany Committer  http://tuscany.apache.org
Apache Geronimo Committer and Member of PMC  http://geronimo.apache.org