OASIS Mailing List ArchivesView the OASIS mailing list archive below
or browse/search using MarkMail.


Help: OASIS Mailing Lists Help | MarkMail Help

virtio-comment message

[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]

Subject: Re: [PATCH RESEND] Documentation: virtio: Add emergency write (emerg_wr) config register in virtio console.

(Replying from correct email address to get it onto virtio-comment)

Pranavkumar Sawargaonkar <pranavkumar@linaro.org> writes:
> This patch updates virtio spec lyx for adding emergency write to 
> virtio console.
> Original patch series related to this is -:
> http://lkml.org/lkml/2013/5/6/167

Great!  Here it is adapted to apply to the current draft.  Note that
"le32" is because v1.0 is always little endian: below it is a note that
it should be native-endian for legacy devices.


diff --git a/content.tex b/content.tex
index 17d1bd7..96645df 100644
--- a/content.tex
+++ b/content.tex
@@ -3225,6 +3225,9 @@ data and outgoing characters are placed in the transmit queue.
 \item[VIRTIO_CONSOLE_F_MULTIPORT (1)] Device has support for multiple
     ports; configuration fields nr_ports and max_nr_ports are
     valid and control virtqueues will be used.
+\item[VIRTIO_CONSOLE_F_EMERG_WRITE (2)] Device has support for emergency write.
+    Configuration field emerg_wr is valid.
 \subsection{Device configuration layout}\label{sec:Device Types / Console Device / Device configuration layout}
@@ -3235,11 +3238,16 @@ data and outgoing characters are placed in the transmit queue.
   is set, the maximum number of ports supported by the device can
   be fetched.
+  If VIRTIO_CONSOLE_F_EMERG_WRITE is set then the driver can use emergency write
+  to output a single character without initializing virtio queues, or even
+  acknowledging the feature.
 	struct virtio_console_config {
 		le16 cols;
 		le16 rows;
 		le32 max_nr_ports;
+                le32 emerg_wr;
@@ -3250,6 +3258,11 @@ native endian of the guest rather than (necessarily) little-endian.
 \subsection{Device Initialization}\label{sec:Device Types / Console Device / Device Initialization}
+\item If the VIRTIO_CONSOLE_F_EMERG_WRITE feature is offered, the
+  emerg_wr field of the configuration can be written at any time.
+  Thus it should work for very early boot debugging output as well as
+  catastophic OS failures (eg. virtio ring corruption).
 \item If the VIRTIO_CONSOLE_F_SIZE feature is negotiated, the driver
   can read the console dimensions from the configuration fields.

[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]