Re: [virtio-comment] VIRTIO Spec feedback

[Rusty Russell <rusty@au1.ibm.com>]

"Michael S. Tsirkin" <mst@redhat.com> writes:
> On Wed, Jan 29, 2014 at 05:05:06PM -0800, Arun Subbarao wrote:
>> Please consider our feedback on the Virtio spec.
>> 
>> regards,
>> Arun.
>> 
>> 
>> ====================================================================
>> Arun Subbarao                                    e: asubbarao@lnxw.com
>> Vice President, Engineering                               v: 408-979-4610
>> LynuxWorks, Inc.                                 f: 408-979-3945
>> 855 Embedded Way                          http://www.lynuxworks.com
>> San Jose, CA  95138                                Open. Reliable. Safe. Secure
>> ====================================================================
>
> one comment is unclear.
> you ask
> 	Any alignment requirements for these three fields?
> 	Whether or not there are any, please state so explicitly.
>
> This is device independent, as such, it's documented
> in 2.4 Virtqueues. There's a table at the end of page 11
> that documents alignment requirements.
> Did you just miss this or is something unclear?

We should insert a cross reference, since there's been a question.

Result below.

Thanks,
Rusty.

diff --git a/content.tex b/content.tex
index 2eb0b26..3b1b14f 100644
--- a/content.tex
+++ b/content.tex
@@ -926,13 +926,13 @@ struct virtio_pci_common_cfg {
         Note: this is *not* an offset in bytes. See notify_off_multiplier below.
 
 \item[queue_desc]
-        The driver writes the physical address of Descriptor Table here.
+        The driver writes the physical address of Descriptor Table here.  See section \ref{sec:Basic Facilities of a Virtio Device / Virtqueues}.
 
 \item[queue_avail]
-        The driver writes the physical address of Available Ring here.
+        The driver writes the physical address of Available Ring here.  See section \ref{sec:Basic Facilities of a Virtio Device / Virtqueues}.
 
 \item[queue_used]
-        The driver writes the physical address of Used Ring here.
+        The driver writes the physical address of Used Ring here.  See section \ref{sec:Basic Facilities of a Virtio Device / Virtqueues}.
 \end{description}
 
 \subsubsection{ISR status structure layout}\label{sec:Virtio Transport Options / Virtio Over PCI Bus / PCI Device Layout / ISR status structure layout}