Re: [virtio-comment] VIRTIO Spec feedback

[Rusty Russell <rusty@au1.ibm.com>]

"Michael S. Tsirkin" <mst@redhat.com> writes:
> On Mon, Feb 10, 2014 at 08:42:18PM +1030, Rusty Russell wrote:
>>   @@ -1234,7 +1234,7 @@ see \ref{sec:Basic Facilities of a Virtio Device / Configuration Space / Legacy
>>    
>>    This documents PCI-specific steps executed during Device Initialization.
>>    As the first step, driver must detect device configuration layout
>>   -to locate configuration fields in memory, I/O or configuration space of the
>>   +to locate configuration fields in memory, I/O or PCI configuration space of the
>>    device.
>>    
>>    \paragraph{Virtio Device Configuration Layout Detection}\label{sec:Virtio Transport Options / Virtio Over PCI Bus / PCI-specific Initialization And Device Operation / Device Initialization / Virtio Device Configuration Layout Detection}
>
> Agree. But this is minor we can just commit this I think.

Sure, we can, but I'm trying to make sure we track feedback correctly,
so I put it all together in the feedback/ dir.

>>   -Some virtio PCI devices can change the device configuration
>>   -state, as reflected in the device-specific region of the device. In this case:
>>   +Some devices can change the device configuration space. In this case:
>>    
>>    \begin{itemize}
>>      \item If MSI-X capability is disabled: an interrupt is delivered and
>
> This looks like a regression to me: "configuration registers" would be
> better and interrupt is always for device-specific region.

We use the term "configuration space" throughout the document, so let's
be consistent.  Perhaps "virtio configuration space"?

Cheers,
Rusty.